Bug 441986 – x11-misc/tinymount uses -Werror during build

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sergey Popov 2012-11-06 06:44:49 UTC]

Created attachment 328520 [details]
build.log

Build.log attached.

my 'emerge --info':

Portage 2.2.0_alpha142 (default/linux/amd64/10.0, gcc-4.5.4, glibc-2.15-r3, 3.5.6-gentoo-JING x86_64)
=================================================================
System uname: Linux-3.5.6-gentoo-JING-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E4500_@_2.20GHz-with-gentoo-2.1
Timestamp of tree: Mon, 05 Nov 2012 20:30:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4-r2 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo kde rion desktop-effects pinkbyte
Installed sets: @kdebase-without-semantic-desktop
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-Os -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Os -pipe -march=native"
DISTDIR="/home/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="ru_RU.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="ru ru_RU"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/home/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/kde /var/lib/layman/rion /var/lib/layman/desktop-effects /var/lib/layman/pinkbyte"
SYNC="rsync://rsync.dstu.local/gentoo-portage"
USE="X aac acl acpi alsa amd64 bash-completion bzip2 cli consolekit cracklib crypt cups cxx dbus dri dvd enca exif fbcon flac fontconfig fortran gif gpm hal iconv idn ipv6 jpeg kde lzma mmx mmxext modules mp3 mudflap multilib ncurses nls nptl ogg opengl openmp pam pcre png policykit pppd qt3support qt4 readline samba semantic-desktop session sndfile sse sse2 ssl ssse3 svg tcpd theora threads tiff truetype unicode usb vorbis wavpack xcb xcomposite xinerama xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default 
authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev ps2mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="ru ru_RU" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" QEMU_SOFTMMU_TARGETS="i386 mipsel x86_64" QEMU_USER_
TARGETS="i386 x86_64" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="vesa nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Mike Limansky 2012-11-06 07:38:23 UTC]

What wrong with -Werror? Do you mean that -Werror is prohibited in Gentoo, because some CFLAGS/CXXFLAGS or compiler versions may lead to errors? 

Actually tinymount is tested with gcc 4.5/4.7 and clang, but if it needed I'll add patch to remove Werror.

[Comment 2 Sergey Popov 2012-11-06 07:54:06 UTC]

(In reply to comment #1)
> What wrong with -Werror? Do you mean that -Werror is prohibited in Gentoo,
> because some CFLAGS/CXXFLAGS or compiler versions may lead to errors? 
> 
> Actually tinymount is tested with gcc 4.5/4.7 and clang, but if it needed
> I'll add patch to remove Werror.

Well, actually it's a QA bug, see Tracker bug - https://bugs.gentoo.org/show_bug.cgi?id=260867 to know why '-Werror' in releases(but not in development) is bad.

[Comment 3 Julian Ospald 2012-11-06 13:28:05 UTC]

if you use specific -Werror that could actually be respected, also see
https://bugs.gentoo.org/show_bug.cgi?id=415979#c6(In reply to comment #1)
> What wrong with -Werror? Do you mean that -Werror is prohibited in Gentoo,
> because some CFLAGS/CXXFLAGS or compiler versions may lead to errors? 
> 
> Actually tinymount is tested with gcc 4.5/4.7 and clang, but if it needed
> I'll add patch to remove Werror.

if you use specific -Werror (e.g. -Werror-implicit-function-declaration), then that could actually be respected, also see comment 6
https://bugs.gentoo.org/show_bug.cgi?id=415979#c6

[Comment 4 Jeroen Roovers (RETIRED) 2012-11-06 15:31:10 UTC]

Index: tinymount-0.2.6.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/x11-misc/tinymount/tinymount-0.2.6.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 tinymount-0.2.6.ebuild
--- tinymount-0.2.6.ebuild      6 Nov 2012 06:39:30 -0000       1.1
+++ tinymount-0.2.6.ebuild      6 Nov 2012 15:30:58 -0000
@@ -47,6 +47,8 @@
        # Prevent disabled locales from being built
        l10n_for_each_disabled_locale_do remove_locale
 
+       sed -i src/src.pro -e 's|-Werror||g' || die # bug #441986
+
        qt4-r2_src_prepare
 }

[Comment 5 Markos Chandras (RETIRED) 2012-11-06 21:03:06 UTC]

+*tinymount-0.2.6-r1 (06 Nov 2012)
+
+  06 Nov 2012; Markos Chandras <[e-mail]>
+  +files/tinymount-0.2.6-libnotify.patch, +tinymount-0.2.6-r1.ebuild:
+  Revbump. Drop -Werror. Bug #442048. Don't build libnotify support
+  unconditionally. Bug #441986
+