Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 437560

Summary: runscript's checkpath non-obvious owner correction
Product: Gentoo Hosted Projects Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: OpenRCAssignee: OpenRC Team <openrc>
Status: RESOLVED FIXED    
Severity: normal CC: robbat2
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 417391    

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-10-08 01:11:33 UTC
This problem was found by Robin and took us a while to find what was going on. What happens is that when you use checkpath, and you don't pass _any_ --owner option, it assumes EUID/GUID pair is what you want to set it to, which in most cases is 0:0.

Now this would be okay _but_ in this case we have a problem as the old munin-node pid file was created in /var/run/munin — which has to be owned by munin:munin. But since munin-node is run as root, it has no -o option. So what happens is that /var/run/munin is changed to be owned by root:root.

Confusing? Quite a bit.

I'd suggest skipping over the whole owner check unless an explicit --owner is passed.
Comment 1 William Hubbs gentoo-dev 2012-10-09 22:02:52 UTC
This has been fixed by commit 6f345ab.
Comment 2 SpanKY gentoo-dev 2012-10-09 23:08:29 UTC
(In reply to comment #1)

on a semi-related note, you should assign "true" and "false" to bool types, not "0" and "1".