Summary: | eutils.eclass: prune_libtool_files, even with --all parameter fails to remove *.la dead symlinks (as shown by =media-libs/libpng-1.5* after replacing the `find`) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Francesco Turco <fturco> |
Component: | Eclasses | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mgorny |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Patch adding symlink removal to the function |
Description
Francesco Turco
2012-10-02 18:06:02 UTC
Fixed by 1.5.13-r1 reopening and refactoring the bug to fix prune_libtool_files to handle dead .la symlinks... (In reply to comment #0) > On my system, /usr/lib64/libpng.la is a broken symlink: > > file /usr/lib64/libpng.la > /usr/lib64/libpng.la: broken symbolic link to `libpng15.la' > > If I remove it and then re-emerge media-libs/libpng-1.5.13, the broken > symlink is recreated. How the hell can you get a symlink .la file? (In reply to comment #3) > (In reply to comment #0) > > On my system, /usr/lib64/libpng.la is a broken symlink: > > > > file /usr/lib64/libpng.la > > /usr/lib64/libpng.la: broken symbolic link to `libpng15.la' > > > > If I remove it and then re-emerge media-libs/libpng-1.5.13, the broken > > symlink is recreated. > > How the hell can you get a symlink .la file? Ah, I see it now... Hmm, any suggestions what would be the best way to handle it? I don't really think stale symlink removal belongs there, so I would probably want to delay removing .la files until after the checking loop, so that both the file and the symlink will be queued for removal. Created attachment 325626 [details, diff]
Patch adding symlink removal to the function
Looks to be fixed in Portage now. + 03 May 2013; Samuli Suominen <ssuominen@gentoo.org> libpng-1.6.2.ebuild: + Use prune_libtool_files --all instead of custom find now that it's capable of + removing dead symlinks too wrt #436996 |