Summary: | net-analyzer/wireshark-1.8.2-r{2,3}: compilation fails with python-3.2 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
Component: | Current packages | Assignee: | Peter Volkov (RETIRED) <pva> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alex, alex_y_xu, alon.barlev, ansla80, aranea, casta, floppym, jano.vesely, mark, netmon, nitro, zerochaos |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
Fix building with python-3 as the active version Patch to remove non-ascii chars from source |
Description
Lars Wendler (Polynomial-C) (RETIRED)
2012-09-18 23:20:16 UTC
Index: wireshark-1.8.2-r2.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.8.2-r2.ebuild,v retrieving revision 1.1 diff -u -B -r1.1 wireshark-1.8.2-r2.ebuild --- wireshark-1.8.2-r2.ebuild 18 Sep 2012 16:48:15 -0000 1.1 +++ wireshark-1.8.2-r2.ebuild 19 Sep 2012 00:15:39 -0000 @@ -3,7 +3,7 @@ # $Header: /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.8.2-r2.ebuild,v 1.1 2012/09/18 16:48:15 jer Exp $ EAPI="4" -PYTHON_DEPEND="python? 2" +PYTHON_DEPEND="2" inherit autotools eutils flag-o-matic python toolchain-funcs user [[ -n ${PV#*_rc} && ${PV#*_rc} != ${PV} ]] && MY_P=${PN}-${PV/_} || MY_P=${P} Would this do it? (In reply to comment #1) > Index: wireshark-1.8.2-r2.ebuild > =================================================================== > RCS file: > /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.8.2-r2.ebuild,v > retrieving revision 1.1 > diff -u -B -r1.1 wireshark-1.8.2-r2.ebuild > --- wireshark-1.8.2-r2.ebuild 18 Sep 2012 16:48:15 -0000 1.1 > +++ wireshark-1.8.2-r2.ebuild 19 Sep 2012 00:15:39 -0000 > @@ -3,7 +3,7 @@ > # $Header: > /var/cvsroot/gentoo-x86/net-analyzer/wireshark/wireshark-1.8.2-r2.ebuild,v > 1.1 2012/09/18 16:48:15 jer Exp $ > > EAPI="4" > -PYTHON_DEPEND="python? 2" > +PYTHON_DEPEND="2" > inherit autotools eutils flag-o-matic python toolchain-funcs user > > [[ -n ${PV#*_rc} && ${PV#*_rc} != ${PV} ]] && MY_P=${PN}-${PV/_} || > MY_P=${P} > > > Would this do it? No. Same error. (In reply to comment #2) > No. Same error. That's a shame. I perhaps incorrectly recalled that setting a dependency like that made python.eclass [R]DEPEND on that version, i.e. dev-lang/python:2.*, since that is what is apparently required in DEPEND, even when not building python support into wireshark (RDEPEND). (In reply to comment #3) > (In reply to comment #2) > > No. Same error. > > That's a shame. I perhaps incorrectly recalled that setting a dependency > like that made python.eclass [R]DEPEND on that version, i.e. > dev-lang/python:2.*, since that is what is apparently required in DEPEND, > even when not building python support into wireshark (RDEPEND). You are right that your change would (R)DEPEND on python2 unconditionally. _But_ I already have both python-2.7 and python-3.2 installed on my machine (as shown in my initial post). The problem appears when python-3 is set as default python version via eselect python set python3.2 (for example) Setting the default python to python-2 makes the error disappear. IMHO this is a regression because =net-analyzer/wireshark-1.8.2{,-r1} compiled fine with python3 being set as default python. Add python to the USE variable for this package. Re-emerge. It worked for me and my system is quite similar to yours. YMMV Bob For what it's worth, I ran into this same issue tonight. Have the exact same error message and python configuration as Lars. Tried adding RESTRICT_PYTHON_ABIS="3.*" to the mix (which I've seen used by other packages that only support Python 2.x), but had no luck. Just confirming and adding myself to the CC list. Created attachment 324366 [details, diff]
Fix building with python-3 as the active version
For me, this fixes the build: always set the active python VM even if USE=python is disabled. And unconditionally depends on python 2.
(In reply to comment #7) > Created attachment 324366 [details, diff] [details, diff] > Fix building with python-3 as the active version > > For me, this fixes the build: always set the active python VM even if > USE=python is disabled. And unconditionally depends on python 2. Ah yes, I missed that second chunk in my patch. Looks good, even though we now remove user control over python support entirely. (In reply to comment #8) > Ah yes, I missed that second chunk in my patch. Looks good, even though we > now remove user control over python support entirely. Yes and no. python is a depend with this change, but the python USE flag still controls the python bindings installation. (In reply to comment #5) > Add python to the USE variable for this package. Re-emerge. It worked for > me and my system is quite similar to yours. YMMV > > Bob Thanks a lot, Bob. Your advice has work out for me. My make.conf USE: USE="mmx sse sse2 consolekit profile ncurses spell dvd dvdread unicode nls bash-completion mysql svg X webkit dbus mng cups winbind kerberos ldap quota swat syslog vim-syntax kde png tiff jpeg alsa gnutls pkcs11 xulrunner ruby qt3support samba crypt lame ffmpeg fts3 semantic-desktop qt4 cairo java nsplugin msn oscar yahoo bonjour symlink sqlite lm_sensors odbc tk a52 aac dts live mp3 quicktime real theora vorbis ssse3 mmxext clucene virtuoso test apache2 threads declarative private-headers -hal policykit udev pam mozilla xvfb ipod schroedinger opengl dri xcomposite cddb id3tag -modplug python3 -gles polkit-kde-agent webgl freetds" # eselect python list Available Python interpreters: [1] python2.7 [2] python3.2 * mk net-analyzer/wireshark-1.8.2-r3 has the same error. Created attachment 324716 [details, diff] Patch to remove non-ascii chars from source Upstream has fixed this by removing all non-ascii characters from the program source code. http://anonsvn.wireshark.org/viewvc?view=revision&revision=43940 I have attached a patch file for this changeset. This is a better solution than trying to force python 2, in my opinion. The patch from Mike fixes the problem. Please apply. (In reply to comment #9) > (In reply to comment #8) > > Ah yes, I missed that second chunk in my patch. Looks good, even though we > > now remove user control over python support entirely. > > Yes and no. python is a depend with this change, but the python USE flag > still controls the python bindings installation. What I meant was that you would end up with an RDEPEND on dev-lang/python-2*. Should have made that more explicit. Patch from comment #12 applied in 1.8.2-r{2,3}. Thanks everyone! *** Bug 436428 has been marked as a duplicate of this bug. *** |