| Summary: | app-text/gv: please review prefix changes | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Christoph Junghans (RETIRED) <junghans> |
| Component: | [OLD] Printing | Assignee: | Printing Team <printing> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | prefix, ssuominen |
| Priority: | Normal | Keywords: | Inclusion, InVCS, PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 315803 | ||
| Attachments: | patch for gv-3.7.3-r1.ebuild | ||
Comment on attachment 324028 [details, diff]
patch for gv-3.7.3-r1.ebuild
- You forgot to remove DOCS after converting away from `default`
- Any app-defaults files installed by ebuilds must go to /usr/share/X11/app-defaults as per the longstanding policy eversince X.org 7.0 was introduced to Portage. And /etc/X11/app-defaults/ is the place where you copy the config, and edit it there if needed. Are you sure the install line is correct, now after hearing this?
- Samuli
(In reply to comment #1) > Comment on attachment 324028 [details, diff] [details, diff] > patch for gv-3.7.3-r1.ebuild > > - You forgot to remove DOCS after converting away from `default` I don't get it, default includes something like "dodoc README* ChangeLog AUTHORS NEWS TODO CHANGES". > - Any app-defaults files installed by ebuilds must go to > /usr/share/X11/app-defaults as per the longstanding policy eversince X.org > 7.0 was introduced to Portage. And /etc/X11/app-defaults/ is the place > where you copy the config, and edit it there if needed. Are you sure the > install line is correct, now after hearing this? You are right, but it seems app-defaults don't get installed anyway $ equery f gv | grep app-defaults So keeping default should be fine and we only need to add keywords. > So keeping default should be fine and we only need to add keywords.
cool. please proceed :)
(In reply to comment #3) > > So keeping default should be fine and we only need to add keywords. > > cool. please proceed :) Done. |
Created attachment 324028 [details, diff] patch for gv-3.7.3-r1.ebuild Changes: - added prefix keywords - install needs appdefaultsdir="${EPREFIX}/etc/X11/app-defaults", but default takes no arguments.