Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 431204

Summary: sys-apps/openrc: net - bridge & iproute2 failed (fixed)
Product: Gentoo Hosted Projects Reporter: Denis Kaganovich <mahatma>
Component: OpenRCAssignee: OpenRC Team <openrc>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard: openrc:oldnet
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 417391    
Attachments: iproute2-dev.patch
bridge-promisc.patch

Description Denis Kaganovich 2012-08-13 11:55:20 UTC
Starting bridge over openrc net scripts via iproute2 failed with message: '"up" is invalid lladdr.'. Looking into /lib*/rc/net/iproute2.sh I found: functions _up() & _down() use short syntax: 'ip link set "${IFACE}" up', but full syntax are: 'ip link set dev "${IFACE}" up' ("dev" required). "Short" syntax works with eth*, but failed with br*. Also you can see help:
# ip link set help
...
ip link set { dev DEVICE | group DEVGROUP } [ { up | down } ]
...
Attaching patch.

Also, I want to suggest one fix (may be not too bug): bridge.sh put bridged interface (eth0,...) into "promisc" mode, but at least working (may be "better", but IMHO more accurate) way to put bridge interface (br*) into "promisc" mode. Current way is widely, but unofficial documented, but "new" - just work for me and don't affect hardware interface if possible. Attaching second patch.

Reproducible: Always
Comment 1 Denis Kaganovich 2012-08-13 12:03:40 UTC
Created attachment 321192 [details, diff]
iproute2-dev.patch
Comment 2 Denis Kaganovich 2012-08-13 12:04:34 UTC
Created attachment 321194 [details, diff]
bridge-promisc.patch
Comment 3 Denis Kaganovich 2012-08-13 12:27:26 UTC
PS About second patch (promisc): it works for bridging eth0 with tap* (qemu). Even if in eth-2-eth it wrong (I don't test it) - IMHO better to prefer less aggressive user config.
Comment 4 William Hubbs gentoo-dev 2012-10-09 22:52:57 UTC
@robbat2: Ping, were you going to apply these or should I go ahead and
apply them?


Thanks,

William
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-10-10 00:11:08 UTC
committed.
Comment 6 Denis Kaganovich 2012-11-11 07:52:00 UTC
PS Now I verify: problem was only for number-less interace ('br', not 'br0'). But all OK. This 'br' works good in other places and after patch.