Summary: | dev-libs/libev ignores user CFLAGS | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Petr Polezhaev <NightNord> |
Component: | [OLD] Library | Assignee: | Yixun Lan <dlan> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | tomka |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Simple patch for configure.ac illustrating the issue |
Description
Petr Polezhaev
2012-08-02 16:29:49 UTC
Created attachment 320088 [details, diff]
Simple patch for configure.ac illustrating the issue
Doesn't apply with libav-ac.patch from tree.
Problem is: one should never place any code prior to AC_INIT - it just don't make it into configure. In Gentoo, I suppose, we may just completely remove this "default flags" hack.
Reassign due to proxy maintainership. your patch looks good to me, also I checked with upstream, they already accepted this fix with a very semilar patch. about the "default flags" hack, although I agree, fallback to a default CFLAGS is useless for gentoo distro, but doesn't hurt here, and also for upstream this will has minimal impact. thanks (In reply to comment #1) Should be fixed in -r1 by upstream's patch (which just moves the offending line until after AC_INIT). |