Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 426314

Summary: app-text/qpdfview-0.3.1-r1 use '--unique' by default
Product: Gentoo Linux Reporter: Vladimir <v_2e>
Component: New packagesAssignee: Samuli Suominen (RETIRED) <ssuominen>
Status: RESOLVED FIXED    
Severity: enhancement CC: qt
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: qpdfview-0.3.1-r1.ebuild
qpdfview-0.3.1-unique.patch

Description Vladimir 2012-07-12 13:00:48 UTC
Created attachment 317990 [details]
qpdfview-0.3.1-r1.ebuild

Hello!
  I suggested to use the '--unique' option by default in app-text/qpdfview , since this behavior is probably expected by the majority of current and potential qpdfview users. Upstream developers agreed to add this option to a default ".desktop" file, which is stated here:

    https://bugs.launchpad.net/qpdfview/+bug/1023840

so I decided to provide a fixed .ebuild and .patch for it.
Thank you.
  Vladimir
Comment 1 Vladimir 2012-07-12 13:01:24 UTC
Created attachment 317992 [details, diff]
qpdfview-0.3.1-unique.patch
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2012-07-12 13:55:21 UTC
For a simple thing like this, a sed works just fine. Committed to CVS.
Comment 3 Franz Trischberger 2012-07-12 15:29:11 UTC
Then commit this fix, too:
http://bazaar.launchpad.net/~adamreichold/qpdfview/trunk/revision/415
because of this bug:
https://bugs.launchpad.net/qpdfview/+bug/1023538

That's one reason why I expect any app to NOT use an existing window to open files in. (The other one is automatic/manual session management; getting random files into the session just because of "--unique", etc. is disturbing)