Summary: | net-p2p/tribler should depend on python version <3.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | PM <mitaspiotr> |
Component: | Current packages | Assignee: | Anthony Basile <blueness> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | casta |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
PM
2012-06-02 11:34:49 UTC
I thought the PYTHON_DEPEND="2:2.7" limited that. Anyhow, I've made the change in the latest ebuild tribler-5.9.12.ebuild and will push forward with that. Can you test to make sure its okay at your end. >I thought the PYTHON_DEPEND="2:2.7" limited that.
Well, I had python installed without sqlite flag and emerging tribler with --autounmask-write re-merged python 3 with this flag enabled instead of python 2.
Hi, A better fix would be to use the PYTHON_USE_WITH="sqlite" variable instead of pulling a python dependency in RDEPEND. This may probably avoid future issue with the python depend. But I'm not very familiar with the python eclass: # diff -u tribler-5.9.12.ebuild.old tribler-5.9.12.ebuild --- tribler-5.9.12.ebuild.old 2012-06-04 15:08:49.466917211 +0200 +++ tribler-5.9.12.ebuild 2012-06-04 15:09:32.582744610 +0200 @@ -4,6 +4,7 @@ EAPI="4" PYTHON_DEPEND="2:2.7" +PYTHON_USE_WITH="sqlite" inherit eutils python @@ -18,8 +19,7 @@ KEYWORDS="~amd64 ~x86" IUSE="vlc" -RDEPEND="<dev-lang/python-3[sqlite] - >=dev-python/m2crypto-0.16 +RDEPEND=">=dev-python/m2crypto-0.16 >=dev-python/wxpython-2.8 >=dev-python/apsw-3.6 >=dev-libs/openssl-0.9.8 (In reply to comment #3) > But I'm not very familiar with the python eclass: Its messy. Let me bounce this question off of some python gurus and see what they say. But after I pushed the change in comment #1, I in fact verified that the PYTHON_DEPEND range is not enough. Okay the gurus tell me: PYTHON_DEPEND="2" PYTHON_USE_WITH="sqlite" I'll commit that now without rev bump. Please test (again) and let me know. FYI: Setting those variables causes python.eclass to emit the following dependency atom: =dev-lang/python-2*[sqlite] It also enables a pkg_setup check to ensure that the currently eselect-ed python2 is built with the sqlite use flag. Seems fine to me, thanks !! |