Summary: | sys-freebsd/freebsd-mk-defs can cause build system to set 444 permissions on directories | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Richard Yao (RETIRED) <ryao> |
Component: | FreeBSD | Assignee: | Gentoo/BSD Team <bsd+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | QA | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | FreeBSD | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 409269 | ||
Attachments: | Revision to freebsd-mk-defs-9.0-gentoo.patch |
Description
Richard Yao (RETIRED)
2012-05-22 08:42:16 UTC
diff to existing patch ? its impossible to review like that Sorry about that. Here is the diff. It is a simple change, so I am posting it inline. All I did was remove the -m option in the extra ${INSTALL} line that was added in share/mk/bsd.incs.mk because ${${group}MODE_${.ALLSRC:T}} is 444. --- freebsd-mk-defs-9.0-gentoo.patch 2011-11-07 07:48:14.000000000 -0500 +++ freebsd-mk-defs-9.0-gentoo-r1.patch 2012-05-22 01:36:57.031266703 -0400 @@ -46,7 +46,7 @@ installincludes: _${group}INS_${header:T} _${group}INS_${header:T}: ${header} + ${INSTALL} -d -o ${${group}OWN_${.ALLSRC:T}} \ -+ -g ${${group}GRP_${.ALLSRC:T}} -m ${${group}MODE_${.ALLSRC:T}} \ ++ -g ${${group}GRP_${.ALLSRC:T}} \ + ${DESTDIR}${${group}DIR_${.ALLSRC:T}} ${INSTALL} -C -o ${${group}OWN_${.ALLSRC:T}} \ -g ${${group}GRP_${.ALLSRC:T}} -m ${${group}MODE_${.ALLSRC:T}} \ (In reply to comment #2) > Sorry about that. Here is the diff. It is a simple change, so I am posting > it inline. All I did was remove the -m option in the extra ${INSTALL} line > that was added in share/mk/bsd.incs.mk because ${${group}MODE_${.ALLSRC:T}} > is 444. > > --- freebsd-mk-defs-9.0-gentoo.patch 2011-11-07 07:48:14.000000000 -0500 > +++ freebsd-mk-defs-9.0-gentoo-r1.patch 2012-05-22 01:36:57.031266703 -0400 > @@ -46,7 +46,7 @@ > installincludes: _${group}INS_${header:T} > _${group}INS_${header:T}: ${header} > + ${INSTALL} -d -o ${${group}OWN_${.ALLSRC:T}} \ > -+ -g ${${group}GRP_${.ALLSRC:T}} -m > ${${group}MODE_${.ALLSRC:T}} \ > ++ -g ${${group}GRP_${.ALLSRC:T}} \ > + ${DESTDIR}${${group}DIR_${.ALLSRC:T}} > ${INSTALL} -C -o ${${group}OWN_${.ALLSRC:T}} \ > -g ${${group}GRP_${.ALLSRC:T}} -m ${${group}MODE_${.ALLSRC:T}} \ oh, yeah, please commit this and make a -r1 of -mk-defs Committed to CVS. |