Summary: | sys-kernel/genkernel should not use the cript use flag | ||
---|---|---|---|
Product: | Gentoo Hosted Projects | Reporter: | William Hubbs <williamh> |
Component: | genkernel | Assignee: | Gentoo Genkernel Maintainers <genkernel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
William Hubbs
2012-05-03 21:15:46 UTC
(In reply to comment #0) > The crypt flag is defined globally as being used to support gpg/gpgme, > and it is on by default in the profiles. > > I am thinking that genkernel shouldn't use this flag for cryptsetup. I see. > I was looking around in the tree and found some packages use the > 'cryptsetup' use flag for this, and I think this would be a good fit for > genkernel. Looks like it's just a single one: # euse -i cryptsetup global use flags (searching: cryptsetup) ************************************************************ no matching entries found local use flags (searching: cryptsetup) ************************************************************ [- ] cryptsetup sys-apps/systemd: Use libcryptsetup [- ] 29-r3 [gentoo] [- ] 29-r6 [gentoo] [- ] 39 [gentoo] [- ] 44-r1 [gentoo] Still, no objections. Any ideas on a smooth use flag rename transition? I would just switch over to the new use flag and put an ewarn in pkg_postinst: if use crypt; then # some warning about the change here. fi Because of portage's --newuse option, you don't need to do a revbump for this type of change. (In reply to comment #2) > I would just switch over to the new use flag and put an ewarn in > pkg_postinst: > > if use crypt; then > # some warning about the change here. > fi For that to work flag "crypt" needs to remain in IUSE one way or another: just verified with portage myself. I have migrated the use flag effect and added this messaging: + if use crypt && ! use cryptsetup ; then + ewarn "Local use flag 'crypt' has been renamed to 'cryptsetup' (bug [..]" + ewarn "Please set flag 'cryptsetup' for this very package if you would like" + ewarn "to have genkernel create an initramfs with LUKS support." + ewarn "Sorry for the inconvenience." + echo + fi Closing. + 03 May 2012; Sebastian Pipping <sping@gentoo.org> genkernel-3.4.30.ebuild, + genkernel-9999.ebuild, metadata.xml: + Migrate from use flag 'crypt' to 'cryptsetup' (bug #414523), sync live ebuild + |