| Summary: | media-sound/qsynth-0.3.6: assorted ebuild improvements | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michael Palimaka (kensington) <kensington> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | EBUILD, PATCH |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 311481 | ||
| Attachments: |
qsynth-0.3.6.ebuild.patch
qsynth-0.3.6.ebuild.patch |
||
+ local lang
+ for lang in ${LANGS} ; do
+ if ! use linguas_${lang} ; then
+ rm -r "${D}"/usr/share/locale/${PN}_${lang}.qm
+ fi
+ done
+
is it really the only way? it'd be cleaner if those files were just not installed.
Created attachment 306993 [details, diff]
qsynth-0.3.6.ebuild.patch
New and improved patch.
(In reply to comment #1) > + local lang > + for lang in ${LANGS} ; do > + if ! use linguas_${lang} ; then > + rm -r "${D}"/usr/share/locale/${PN}_${lang}.qm > + fi > + done > + > > is it really the only way? it'd be cleaner if those files were just not > installed. Yes if upstream do the localization not in the standard style. Alexis, ping? It may not be perfect, but I can't see this a valid reason to hold up the qt4-r2 migration, so go ahead and apply the patch We can improve *the style* for linguas handling in a version/revision bump later Or rather just leave the linguas handling out of the patch and migrate the ebuild to qt4-r2 in a trivial way to avoid the hold up. (In reply to comment #2) > Created attachment 306993 [details, diff] [details, diff] > qsynth-0.3.6.ebuild.patch > > New and improved patch. sorry, forgot to reply here... this new patch sounds good, feel free to apply, thanks Applied in CVS. Thanks Michael for the patch! |
Created attachment 306973 [details, diff] qsynth-0.3.6.ebuild.patch While intended to primarily migrate to the qt4-r2 eclass, the attached ebuild patch also bumps EAPI and respects LINGUAS.