Bug 406097 – x11-misc/obconf-2.0.3_p20111019: remove lxde from USE, workaround no longer needed

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Sławomir Nizio 2012-02-28 01:41:48 UTC]

According to my test, workaround introduced to resolve bug 369555 on 
x11-misc/obconf is not needed (can anyone confirm?).

So lxde from USE and that wrapper doesn't need to be installed, 
fortunately and finally!

How I tested: I ran 'obconf' (not 'obconf-lxde') from the terminal, and 
with new obconf (x11-misc/obconf-2.0.3_p20111019):

a) Openbox (x11-wm/openbox-3.5.0_p20111019) not in LXDE -> works OK - changes introduced there take place immediately,

b) Openbox in LXDE -> same here, works OK.

Always the correct config file is chosen.

see also: https://bugzilla.icculus.org/show_bug.cgi?id=5046#c2

--

By the way, there's a typo in obconf ebuild in RDEPEND.

there is: >=x11-wm/openbox-3.5.0_pre20111019
should be: there is: >=x11-wm/openbox-3.5.0_p20111019 (_p, not _pre)

[Comment 1 Markos Chandras (RETIRED) 2012-02-29 17:46:13 UTC]

'lxde' flag is still needed otherwise I wouldn't have add it there in the first place. I will fix the typo nonetheless

[Comment 2 Sławomir Nizio 2012-02-29 20:29:38 UTC]

Well, it seemed for me OK for some reason - otherwise I wouldn't have filed the report. Anyway, I've asked to confirm it (or not) and I got it. Thx.

[Comment 3 Markos Chandras (RETIRED) 2012-02-29 21:03:29 UTC]

bug #369555 explains why this flag is there ;)

[Comment 4 Sławomir Nizio 2012-02-29 21:44:50 UTC]

(In reply to comment #3)
> bug #369555 explains why this flag is there ;)

Yes, but I think it's fixed upstream, available out of the box in the newest obconf from Portage. :)

Comment 1 from the mentioned bug says:
"The application is attempting to access the file lxde-rc.xml in the directory "/home/bill/.config/openbox/home/bill/.config/openbox/" which by default doesn't exist."

I can reproduce that bug with x11-misc/obconf-2.0.3_p20110314-r1.
However, I'm no longer able to reproduce bug #369555 with x11-misc/obconf-2.0.3_p20111019, so it seems fixed to ME upstream. And thus I'm requesting to remove this workaround so obconf run from menu would work in LXDE and any other session using Openbox.

Strace from "old" obconf (terminal: 'obconf') run under LXDE (startx … startlxde - I don't use any login manager) shows the "double" faulty path as seen above, but with the "new" obconf, x11-misc/obconf-2.0.3_p20111019 shows correct one (on both openbox-session and lxde session).

I believe upstream commit to obconf, this one:

cc7a18807663313ef111d86a75844ded0416a889
Load the rc.xml config file given on --config-file the same as Openbox (use the whole path given).

fixes bug #369555, thus workaround isn't needed (even though the comment isn't too clear about it).

If for some reason it's only working on my system, but not in general or for you (strange?), sorry for the noise.

Cheers!

[Comment 5 Markos Chandras (RETIRED) 2012-03-01 08:24:25 UTC]

I may commit a masked version for further testing as I am not using LXDE myself

[Comment 6 Markos Chandras (RETIRED) 2012-03-02 21:01:42 UTC]

Ok useflag dropped. No revbump

[Comment 7 Sławomir Nizio 2012-03-02 22:31:42 UTC]

I'd also change ">x11-misc/obconf-2.0.3-r1[lxde]" in lxde-base/lxde-meta ebuilds because it's no longer valid for p20111019. :)