Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 406053

Summary: elisp-common.eclass and xemacs-elisp-common.eclass namespace collision (was: app-admin/puppet installs xemacs files instead of emacs files)
Product: Gentoo Linux Reporter: Tom Prince <tom.prince>
Component: EclassesAssignee: XEmacs team <xemacs>
Status: RESOLVED FIXED    
Severity: normal CC: emacs, matsuu
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge --info
build.log

Description Tom Prince 2012-02-27 17:29:33 UTC
Created attachment 303517 [details]
emerge --info

/usr/share/xemacs is created and populated, while nothing is put in /usr/share/emacs
Comment 1 Tom Prince 2012-02-27 17:34:44 UTC
Created attachment 303519 [details]
build.log
Comment 2 MATSUU Takuto (RETIRED) gentoo-dev 2012-03-14 17:55:11 UTC
Fixed in cvs.
Comment 3 Ulrich Müller gentoo-dev 2012-04-05 14:09:58 UTC
Why has nobody CCed the emacs and xemacs teams here?

The problem lies deeper, elisp-common.eclass and xemacs-elisp-common.eclass both assign the SITELISP variable. Probably one of them (at least) should rename it.

AFAICS, xemacs-common.eclass is inherit by the following packages only:
   app-admin/puppet
   app-xemacs/gentoo-syntax
   sci-mathematics/octave
Out of these, only puppet-2.7.12.ebuild uses the SITELISP variable directly.

@graaff: Would it be possible for you to rename the variable in xemacs-elisp-common.eclass? (And maybe rename SITEPACKAGE too, for consistency?) Renaming it in elisp-common.eclass would require many times more effort, because it is inherited by some 500 ebuilds.
Comment 4 Hans de Graaff gentoo-dev Security 2012-04-07 08:48:08 UTC
(In reply to comment #3)

> @graaff: Would it be possible for you to rename the variable in
> xemacs-elisp-common.eclass? (And maybe rename SITEPACKAGE too, for
> consistency?) Renaming it in elisp-common.eclass would require many times
> more effort, because it is inherited by some 500 ebuilds.

Sure, that sounds like the best solution. I'll see if I can find some time for that this weekend.
Comment 5 Ulrich Müller gentoo-dev 2012-05-19 16:30:04 UTC
Fixed in xemacs-elisp-common.eclass, as discussed in IRC:
SITELISP is now XEMACS_SITELISP,
SITEPACKAGES is now XEMACS_SITEPACKAGES.

I've also changed the app-admin/puppet-2.7.{12,13} ebuilds accordingly.
Comment 6 Ulrich Müller gentoo-dev 2012-05-19 16:31:30 UTC
(In reply to comment #5)
> SITEPACKAGES is now XEMACS_SITEPACKAGES.

This should read "SITEPACKAGE" and "XEMACS_SITEPACKAGE".