Summary: | www-client/firefox-10.0 has hardcoded CFLAGS and GCC dependency | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Richard Yao (RETIRED) <ryao> |
Component: | Current packages | Assignee: | Richard Yao (RETIRED) <ryao> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | mozilla, nikoli |
Priority: | Normal | Keywords: | Goal, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 408963 | ||
Attachments: |
Build failure demonstrating that gcc is hard coded, custom-cflags is respected, but custom-optimization is ignored
Initial patch to remove hard coded GCC references |
Description
Richard Yao (RETIRED)
2012-02-11 03:03:23 UTC
Created attachment 301525 [details]
Build failure demonstrating that gcc is hard coded, custom-cflags is respected, but custom-optimization is ignored
As an addendum, I would like to state that this does obey custom-cflags, but not custom-optimization. I just tried compiling with custom-cflags to test it and it failed because GCC was passed flags meant for ICC.
ping me when you have something you would like me to review. Created attachment 314751 [details, diff]
Initial patch to remove hard coded GCC references
This is a patch that I wrote on Gentoo FreeBSD when trying to compile Firefox with Clang. I am not passing any flags that Clang accepts that GCC does not, so I have not yet verified that I have caught all hard coded references.
I do not anticipate pushing forward very far with this right now, but I am posting it in advance so people can comment for the future me (or someone else) that finishes this.
(In reply to comment #3) > Created attachment 314751 [details, diff] [details, diff] > Initial patch to remove hard coded GCC references > > This is a patch that I wrote on Gentoo FreeBSD when trying to compile > Firefox with Clang. I am not passing any flags that Clang accepts that GCC > does not, so I have not yet verified that I have caught all hard coded > references. > > I do not anticipate pushing forward very far with this right now, but I am > posting it in advance so people can comment for the future me (or someone > else) that finishes this. If I recall correctly, Firefox 14 resolved the issues compiling Firefox with Clang. Closing as fixed. |