Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 402473

Summary: new package: kde-misc/kolor-manager
Product: Gentoo Linux Reporter: darkbasic <darkbasic>
Component: [OLD] KDEAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: enhancement CC: creffett, xmw
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 402785    
Bug Blocks:    
Attachments: kolor-manager-9999.ebuild
kolor-manager-9999.ebuild

Description darkbasic 2012-02-07 00:13:22 UTC
http://quickgit.kde.org/?p=kolor-manager.git&a=blob&f=README
http://www.oyranos.org/wiki/index.php?title=Kolor-manager

We recently get media-libs/oyranos-0.3.2 in portage, it would be nice to have kolor-manager too.
Comment 1 Chris Reffett (RETIRED) gentoo-dev Security 2012-02-08 02:25:07 UTC
Created attachment 301205 [details]
kolor-manager-9999.ebuild

Since it's git-only right now I made a live ebuild for it. Built successfully on my laptop, but I'm not very experienced at ebuild writing so it probably needs some cleaning up or revising.
Comment 2 darkbasic 2012-02-08 11:40:24 UTC
Thanks, I'm wondering why they don't mainline it: kde really lacks proper color management (the whole desktop environment should be color managed, they should make the kde libraries color aware). Hopefully kde5 will be color aware? I fear it will not :(
Comment 3 Maciej Mrozowski gentoo-dev 2012-02-08 19:02:56 UTC
(In reply to comment #1)
> Since it's git-only right now I made a live ebuild for it. Built successfully
> on my laptop, but I'm not very experienced at ebuild writing so it probably
> needs some cleaning up or revising.

1. Use KDE_SCM and EGIT_REPONAME variables, no need explicit inherit of git-2
Example: http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=blob;f=x11-themes/oxygen-transparent/oxygen-transparent-9999.ebuild
2. Set license to appropriate one.
3. DEPEND could use better formating:
Example guide regarding ebuild formatting (at the end): http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=blob;f=Documentation/CODE
Comment 4 Chris Reffett (RETIRED) gentoo-dev Security 2012-02-08 20:25:21 UTC
Created attachment 301299 [details]
kolor-manager-9999.ebuild

Okay, ebuild attempt number 2. Changes:
1. Added license as BSD-2, as the source files contain a header that is nearly identical to the BSD-2 license in /usr/portage/licenses. It's not quite the same, though, there are some minor differences, and I'm not sure how strict the wording has to be. Would appreciate comment on this.
2. Removed dependency on git-2, and since the ebuild name is the same as the repo name, I don't need to specify EGIT_REPONAME as long as KDE_SCM is specified.
3. Reformatted the file to match the example ebuild and the guidelines provided for DEPEND
4. Put it in SLOT="4" because it is a package for kde4 and I was told that is the proper slot for kde4 packages.
Comment 5 darkbasic 2012-02-09 15:29:10 UTC
Awesome, it's already in the kde overlay :)
Comment 6 Johannes Huber (RETIRED) gentoo-dev 2012-02-10 09:17:50 UTC
+*kolor-manager-0_p20120210 (10 Feb 2012)
+
+  10 Feb 2012; Johannes Huber <johu@gentoo.org>
+  +kolor-manager-0_p20120210.ebuild, +metadata.xml:
+  New package wrt bug #402473. Initial ebuild by Chris Reffett
+  <geekboy72@gmail.com>.