Summary: | [PATCH] dev-lang/spidermonkey-1.8.5-r1: fix armv7 compilation | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Fabio Erculiani (RETIRED) <lxnay> |
Component: | New packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anarchy, arm, djc |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugzilla.mozilla.org/show_bug.cgi?id=608803 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | armv7 compilation patch |
Description
Fabio Erculiani (RETIRED)
2012-01-29 18:01:12 UTC
Created attachment 300301 [details, diff]
armv7 compilation patch
Some clarifications: First of all armv7 has hardware floating point unit and forcing -float-abi=softfp would make gcc fail miserably on a hardfp (hardware floating point) system. Secondly, at least for armv7 (but i also guess it's the same for other arm arches), TARGET_CPU is something like "armv7" and not just "arm", so we really need to use findstring rather than doing exact matching. Failing to do so has the consequence of some source files not being included for compilation, resulting in linking failure (undefined symbols). Thanks for reporting and clarifing all fixed in cvs. |