Summary: | www-plugins/google-talkplugin-2.5.6.0 - Updated ebuild to add screen sharing and LINGUAS support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeff Simpson <jeffsimpson> |
Component: | New packages | Assignee: | Christoph Junghans (RETIRED) <junghans> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | desktop-misc |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Add screen sharing and linguas support to google-talkplugin
adds glade USE flag and dep if needed |
Description
Jeff Simpson
2012-01-03 06:44:53 UTC
Created attachment 297757 [details]
Add screen sharing and linguas support to google-talkplugin
This ebuild adds screen sharing support to google-talkplugin
Created attachment 297769 [details, diff]
adds glade USE flag and dep if needed
The LINGUAS support works as submitted in the attachement.
The windowpicker.glade file is needed for screen sharing and works as submitted but the submitted ebuild does not check for glade as a needed dep or before installing the glade file.
Submitting ebuild patch (applied to original bug attachment) to add glade to IUSE and (conditionally to) NATIVE_DEPS and then only install the glade file if needed.
Looks good to me, but I would opt for not adding glade unconditionally. I just tested this out - neither glade, nor libglade, nor any other package with glade in the name is needed. I'm guessing libglade must be compiled into the plugin. That would explain why neither the Ubuntu nor Redhat packages have a dependency on anything glade-related. Can we revert back to not having a glade useflag? fixed in google-talkplugin-2.5.6.0-r1 - please test google-talkplugin-2.5.6.0-r1 in portage installed and worked for me. Thanks! |