Summary: | kde-base/kcalc-4.7.3 fails tests | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paweł Hajdan, Jr. (RETIRED) <phajdan.jr> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | esigra |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://bugs.kde.org/show_bug.cgi?id=302848 | ||
Whiteboard: | fixed in 4.10.0 | ||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 241922 | ||
Attachments: |
build.log.gz
Test log with X and DBUS, 1 of 1 fail |
Description
Paweł Hajdan, Jr. (RETIRED)
2011-12-04 09:21:17 UTC
Created attachment 294761 [details]
Test log with X and DBUS, 1 of 1 fail
Testing result of: KNumber(5) + KNumber("2/3") should give 17/3 and gives 7.3.... The type of the result should be Fraction and gives Float.... Failed That's actually a real test failure, yay! Anyway, restricted. diff -ur kcalc-4.7.3.orig/kcalc/knumber/tests/knumbertest.cpp kcalc-4.7.3/kcalc/knumber/tests/knumbert$ --- kcalc/knumber/tests/knumbertest.cpp 2011-10-28 15:53:24.000000000 +0800 +++ kcalc/knumber/tests/knumbertest.cpp 2012-01-13 15:40:00.245003467 +0800 It appears kcalc is in some trouble. +// checkResult("KNumber(5) + KNumber(\"2/3\")", KNumber(5) + KNumber(QLatin1String("2.3")), "17/3", KNumber::FractionType); became +// checkResult("KNumber(5) + KNumber(\"2/3\")", KNumber(5) + KNumber(QLatin1String("2.3")), "17/3", KNumber::FractionType); +// checkResult("KNumber(\"5/3\") + KNumber(\"2/3\")", KNumber(QLatin1String("5/3")) + KNumber(QLatin1String("2.3")), "7/3", KNumber::FractionType); which became +// checkResult("KNumber(5) + KNumber(\"2/3\")", KNumber(5) + KNumber(QLatin1String("2.3")), "17/3", KNumber::FractionType); +// checkResult("KNumber(\"5/3\") + KNumber(\"2/3\")", KNumber(QLatin1String("5/3")) + KNumber(QLatin1String("2.3")), "7/3", KNumber::FractionType); +// checkResult("KNumber(5) - KNumber(\"2/3\")", KNumber(5) - KNumber(QLatin1String("2.3")), "13/3", KNumber::FractionType); at which point the point is made. The common denominator is KNumber::FractionType which it appears has failed the test. In typical test style, it bailed out at the first error, masking the many others. On removing the first, the second appeared, and on removing the second, the third appeared, and so on. The instances of KNumber::FractionType in the file knumbertest.cpp is pretty high. At face value the kcalc ::FractionType() is shattered. Needs sending upstream Submitted a patch for the 2.3 versus 2/3 problem upstream (after all this is just a bug in the test program). Unfortunately this does not help much, as KNumber has serious problems keeping -inf and inf apart... :| 4.10.0 is in the tree with fixed tests, and previous versions are restricted. |