Bug 387087 – x11-libs/pixman: non POSIX test

• Product: Gentoo/Alt
• Status: RESOLVED FIXED

[Description Naohiro Aota 2011-10-14 03:46:54 UTC]

ERROR: compile
Found a non POSIX test construction in a configure script

" test "$test_CFLAGS" == "" && \" should be the problem line.

[Comment 1 Naohiro Aota 2011-10-14 03:49:27 UTC]

Created attachment 289773 [details, diff]
files/pixman-0.22.2-posix-test.patch

Patch for the configure.ac

[Comment 2 Naohiro Aota 2011-10-14 03:50:15 UTC]

Created attachment 289775 [details, diff]
pixman-0.22.2.ebuild.patch

Patch for the ebuild

[Comment 3 Naohiro Aota 2011-10-14 03:54:10 UTC]

x11 team,

Could you review these patch please? This patch should replace non
POSIX test with POSIX compliant one.

Confirmed it get built both on Linux and FreeBSD without QA warns.

Thanks in advance.

[Comment 4 Matt Turner 2011-10-14 03:55:36 UTC]

(In reply to comment #1)
> Created attachment 289773 [details, diff]
> files/pixman-0.22.2-posix-test.patch
> 
> Patch for the configure.ac

Want me to send this upstream?

[Comment 5 Naohiro Aota 2011-10-14 04:07:51 UTC]

(In reply to comment #4)
> (In reply to comment #1)
> > Created attachment 289773 [details, diff]
> > files/pixman-0.22.2-posix-test.patch
> > 
> > Patch for the configure.ac
> 
> Want me to send this upstream?

oh, please go ahead :)

[Comment 6 Michał Górny 2011-10-14 05:52:01 UTC]

LGTM. Although you should take a look what upstream style is, autoconf mans prefer x"$foo" == x"", I think.

[Comment 7 Naohiro Aota 2011-11-25 00:26:44 UTC]

Reported upstream and they added the patch.

https://bugs.freedesktop.org/show_bug.cgi?id=42588

Applied in Gentoo ebuild also. Thanks.