Summary: | gnome-extra/gpointing-device-settings-1.5.1-r2 fails to build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Allan Gottlieb <gottlieb> |
Component: | [OLD] GNOME | Assignee: | Peter Volkov (RETIRED) <pva> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | battle.jerboa, slyfox, tetromino, travisghansen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build log
Requested build log proposed patch |
Description
Allan Gottlieb
2011-09-21 18:01:15 UTC
Created attachment 287337 [details]
build log
Thank you for report. Fixed in gpointing-device-settings-1.5.1-r2. (In reply to comment #2) > Thank you for report. Fixed in gpointing-device-settings-1.5.1-r2. I am not sure I understand. The bug concerns version 1.5.1-r2. Also I resynced today and 1.5.1-r2 is the current version and the same error occurs today as originally reported. Has the fixed version hit the tree yet? If so, does it have version bump? thanks It was fixed with this commit: 02 Oct 2011; Peter Volkov <pva@gentoo.org> gpointing-device-settings-1.5.1-r2.ebuild: Fix build failure reported in bug #384001 (wrt Allan Gottlieb). or more specifically does your ebuild has: sed 's|\(^GPDS_CFLAGS=.*-D[A-Z_]*_DISABLE_DEPRECATED.*\)|#\1|' \ -i configure.ac || die If yes, please, attach full build log. (In reply to comment #4) > or more specifically does your ebuild has: > sed 's|\(^GPDS_CFLAGS=.*-D[A-Z_]*_DISABLE_DEPRECATED.*\)|#\1|' \ > -i configure.ac || die > > > If yes, please, attach full build log. It does have that sed line (right before eautoreconf). I am attaching a build log in few minutes. thanks. Created attachment 288809 [details]
Requested build log
Same behavior here. Got error of same origin on amd64 arch CCLD libpointing-device.la /usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: .libs/libpointing_device_la-gsd-pointing-device-plugin.o: relocation R_X86_64_PC32 against undefined symbol `gsd_pointing_device_plugin_class_finalize' can not be used when making a shared object; recompile with -fPIC /usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: final link failed: Bad value Created attachment 300743 [details, diff]
proposed patch
Enclosed a fix for my case (amd64). Haven't tested it anywhere else, though
The patch works and seems to be the correct approach. It seems that older gcc versions echoed a warning regarding this problem: gsd-pointing-device-plugin.c:59:1: warning: 'gsd_pointing_device_plugin_class_finalize' used but never defined [enabled by default] Using the proposed patch it takes only one additional line to the epatch section of the existing ebuild. How about adding it? Patch (comment 9) works for me too (i686-pc-linux-gnu-4.5.3) Pushed the fix:
> 03 Mar 2012; Sergei Trofimovich <slyfox@gentoo.org>
> +files/gpointing-device-settings-1.5.1-gsd-3.2-fix.patch,
> gpointing-device-settings-1.5.1-r2.ebuild:
> Fixed build failure aginst gnome-base/gnome-settings-daemon-3.2.2 (undefined
> gsd_pointing_device_plugin_class_finalize); bug #384001 by Allan Gottlieb and
> others. Patch provided by battle.jerboa@gmail.com.
But! I don't use it. So please check if the plugin actually works.
Thanks for the report and fix guys!
|