Summary: | app-emulation/xen-tools-4.1.2-r2[custom-cflags] does not respect "-O?" | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | New packages | Assignee: | Ian Delaney (RETIRED) <idella4> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | gentoo, xen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | revised patch |
Description
Agostino Sarubbo
2011-09-21 16:13:08 UTC
+*xen-tools-3.4.2-r4 (25 Sep 2011) + + 25 Sep 2011; Tony Vroon <chainsaw@gentoo.org> +xen-tools-3.4.2-r4.ebuild, + +files/xen-tools-3.4.2-remove-default-cflags.patch: + Proxy commit for Ian "idella4" Delaney. Be more thorough for custom-cflags + and use a diff instead of sed magic, closes bug #383975. Use toolchain-funcs + to invoke correct compiler, closes bug #383973. Not fixex :/ x86_64-pc-linux-gnu-gcc -march=native -O2 -g0 -fno-strict-overflow -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .subdirs-all.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .subdir-all-libxc.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .build.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xen/common/libelf -Wmissing-prototypes -I. -I../xenstore -I../include -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xc_core.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xen/common/libelf -Wmissing-prototypes -I. -I../xenstore -I../include -c -o xc_core.o xc_core.c Created attachment 287799 [details, diff]
revised patch
Captures -O1 and all -g
This may be over zealous. Yet to know archtester work # grep xc_core.c ../temp/build.log x86_64-pc-linux-gnu-gcc -march=native -pipe -O3 -fno-strict-overflow -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .subdirs-all.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .subdir-all-libxc.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .build.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xen/common/libelf -Wmissing-prototypes -I. -I../xenstore -I../include -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xc_core.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xen/common/libelf -Wmissing-prototypes -I. -I../xenstore -I../include -c -o xc_core.o xc_core.c ok, the last patch works for me. @xen, please bump and mark as resolved fixed *** Bug 384363 has been marked as a duplicate of this bug. *** It happens again: x86_64-pc-linux-gnu-gcc -O2 -pipe -g0 -fno-strict-overflow -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .subdirs-all.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .subdir-all-console.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .main.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Werror -I/var/tmp/portage/app-emulation/xen-tools-4.1.2-r2/work/xen-4.1.2/tools/console/../../tools/libxc -I/var/tmp/portage/app-emulation/xen-tools-4.1.2-r2/work/xen-4.1.2/tools/console/../../tools/include -I/var/tmp/portage/app-emulation/xen-tools-4.1.2-r2/work/xen-4.1.2/tools/console/../../tools/xenstore -I/var/tmp/portage/app-emulation/xen-tools-4.1.2-r2/work/xen-4.1.2/tools/console/../../tools/include -c -o daemon/main.o daemon/main.c This find "${S}" -name Makefile -o -name Rules.mk -o -name Config.mk -exec sed \ -e 's/CFLAGS\(.*\)=\(.*\)-O3\(.*\)/CFLAGS\1=\2\3/' \ -e 's/CFLAGS\(.*\)=\(.*\)-march=i686\(.*\)/CFLAGS\1=\2\3/' \ -e 's/CFLAGS\(.*\)=\(.*\)-fomit-frame-pointer\(.*\)/CFLAGS\1=\2\3/' \ -e 's/CFLAGS\(.*\)=\(.*\)-g3*\s\(.*\)/CFLAGS\1=\2 \3/' \ -e 's/CFLAGS\(.*\)=\(.*\)-O2\(.*\)/CFLAGS\1=\2\3/' \ -i {} \; || die "failed to re-set custom-cflags" is already long in place to address the default custom-cflags. The last patch was brutal and considered an imposition on the upstream's settings. This will go to a higher level. dropped from portage |