| Summary: | app-admin/gam-server does not build with recent dev-libs/glib | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Maciej Piechotka <uzytkownik2> |
| Component: | New packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, xfce |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugzilla.gnome.org/show_bug.cgi?id=658884 | ||
| Whiteboard: | tracking upstream | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 384779 | ||
| Attachments: | 0001-Fix-compilation-of-recent-glib-removing-G_CONST_RETU.patch | ||
|
Description
Maciej Piechotka
2011-09-13 07:49:42 UTC
Created attachment 286301 [details, diff]
0001-Fix-compilation-of-recent-glib-removing-G_CONST_RETU.patch
Patch fixing the problem.
Ook... since I have absolutely no clue about this, let's wait for review from upstream. (In reply to comment #2) > Ook... since I have absolutely no clue about this, let's wait for review from > upstream. No need to wait, the patch is obviously correct. Simply take a look at /usr/include/glib-2.0/glib/gmacros.h installed by glib-2.29.x: /* Deprecated -- do not use. */ #ifndef G_DISABLE_DEPRECATED #ifdef G_DISABLE_CONST_RETURNS #define G_CONST_RETURN #else #define G_CONST_RETURN const #endif #endif In other words, unless G_DISABLE_CONST_RETURNS is defined (and I have never, ever seen it defined), G_CONST_RETURN is precisely "const". Since using a 14-character macro to define a 5-character keyword is obviously silly cruft, glib developers have deprecated it, and will likely remove it in a future version. So the solution is to either (a) replace all instances of G_CONST_RETURN with const (as in Maciej's patch), or (b) ensure that configure and makefiles do not add G_DISABLE_DEPRECATED to CFLAGS (which will work for now, but will break when a near-future version of glib fully drops the deprecated macro from public headers). Upstream gnome developers always opt for solution (a). For example, see commits such as the following: http://git.gnome.org/browse/gtk+/commit/?id=bf0d8402f5382fadd32a9748d00a4bcd715ea07a + 25 Sep 2011; Pacho Ramos <pacho@gentoo.org> gam-server-0.1.10.ebuild, + +files/gam-server-0.1.10-G_CONST_RETURN-removal.patch, + +files/gam-server-0.1.10-armel-features.patch, + +files/gam-server-0.1.10-crosscompile-fix.patch: + Fix compilation with latest glib, bug #382783 by Maciej Piechotka; fix + crosscompilation issues, bug #267604 by Andrei Slavoiu; enable linux specific + features on armel, upstream bug #588338; drop DG_DISABLE_DEPRECATED; don't + try to even check for python, simplifying ebuild for people running python3 + as main interpreter; use gnome.org eclass to set SRC_URI and use bz2 tarball + instead of gz. + |
