Summary: | media-sound/aqualung-0.9_beta11-r1 does not respect CFLAGS | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Daniel Pielmeier <billie> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | sound |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Agostino Sarubbo
2011-07-29 10:36:59 UTC
Does it work if you build with USE="-debug". I only get this output with the debug USE flag enabled. You are correct with not respecting CFLAGS, as it appends -O2 for release (USE="-debug") builds. This should be fixed now. from aqualung configure.ac it does: 11 AC_ARG_ENABLE( 12 debug, 13 [ --enable-debug=yes,no compile with debugging support (default: no)], 14 debug="$enableval", 15 debug="no") 16 if test "$debug" = "yes"; then 17 buildtype=debug 18 BUILD_CFLAGS="-rdynamic -ggdb -g -O0" 19 AC_DEFINE([DEBUG_BUILD], [1], [Defined if doing a debug build]) 20 AC_MSG_RESULT(debug) 21 else 22 buildtype=release 23 BUILD_CFLAGS="-O2" 24 AC_DEFINE([RELEASE_BUILD], [1], [Defined if doing a release build]) 25 AC_MSG_RESULT(release) 26 fi and later: 944 CFLAGS="$CFLAGS $BUILD_CFLAGS -Wall $PLATFORM_CFLAGS $AQUALUNG_SKINDIR $AQUALUNG_LOCALEDIR $AQUALUNG_DATADIR -D_GNU_SOURCE" If you enable debugging it appends "-rdynamic -ggdb -g -O0" and if you disable it "-O2" is appended. For debugging I would say it is okay to append those flags but it should not append anything for a non debug build as this overwrites the users CFLAGS thus I removed the -O2 for release build via sed. Another possible solution would be to put $BUILD_CFLAGS before $CFLAGS. This way the user specified CFLAGS are respected in any case. any USEFLAGS must not edits cflags environment. + 07 Aug 2011; Samuli Suominen <ssuominen@gentoo.org> + aqualung-0.9_beta11-r1.ebuild: + Leave setting -g and -O levels to user with debug build wrt #376895 |