Summary: | media-gfx/gimp-2.0_pre1 has hardcoded --disable-print | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Henrik Brix Andersen <henrik> |
Component: | [OLD] Printing | Assignee: | foser (RETIRED) <foser> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | latexer, printing |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
gimp-2.0_pre1-r1 ebuild with gimp-print support
patch for gimp-2.0_pre1-r1.ebuild |
Description
Henrik Brix Andersen
2004-01-09 05:51:05 UTC
Well as is noted in the ebuild thats a FIXME, so patches are accepted. I disabled it early on because of problems with gimp-print versioning in our tree iirc and do want it reenabled when it reaches 2.0 . Why doesn't it work with 4.3 btw, isn't that more recent ? gimp-print-4.3.x is a development version of gimp-print. The API changed drastically since 4.2.x. When the gimp-print developers release the next stable version of gimp-print, 4.4.x, the gimp print plug-in will of course be updated to this new API. I'll try to come up with a patch to the ebuild - but I'm quite busy with the gimp pre-releases these days. so we'll have support for it when it comes out ;) Support for printing from gimp-2.0 when gimp-print 4.4.0 comes out? Even though the gimp-2.0 print plug-in will work wil gimp-print 4.2.x which is also in portage? That is not acceptable imho. and its not what i meant... it got to be in before 2.0 . It's probably as simple as a gimp-print dep, appropriate USE flag and switch. gimp-print does not support gimp-1.3/2.0 currently! From the gimp-print releasenotes: The Print plug-in for the GIMP requires the GIMP 1.2 (more recent versions of the GIMP, such as 1.3, are not supported at present). I am a GIMP developer. I think I know what I am talking about here... GIMP 1.3.x/2.0pre1 works fine with gimp-print-4.2.x. It does not work with gimp-print versions 4.3.0 and above since these are unstable developer versions. When gimp-print-5.0 is released we will of course update the print plug-in found in The GIMP to work with the new gimp-print API. But since gimp-print-4.2.x _is_ in portage there is no need for hardcoding --disable-print in the gimp2.0_pre1 ebuild. Heck, the gimp configure script even checks for a supported version of gimp-print. A USE flag could be added to the gimp-2.0 ebuilds so the user could specify if he wants printing support or not. If the user requires printing support the gimp ebuild should depend on gimp-print-4.2.x. Quite simple. Created attachment 23877 [details]
gimp-2.0_pre1-r1 ebuild with gimp-print support
Attached is a gimp-2.0_pre1-r1 which i made up after talking to brix in
#gentoo-laptop about this issue. Conditionally adds gimp-print dep and option
based on USE="gimp-print" (there's no real good global USE i found when quickly
searching use.desc).
This should pretty clearly demonstrate the new gimp's ability to print/work
with gimp-print.... (:
(diffs work better to demonstrate changes) Looks ok to me, one FIXME can be removed as well. I would opt for a USE flag name without '-', so just 'gimpprint'. I know more local use flags do it, but i'm not sure it's a good practice. Don't know much about gimp-print, but isn't it a runtime dep as well ? Fix/check these issues & feel free to put it in. Created attachment 23913 [details, diff]
patch for gimp-2.0_pre1-r1.ebuild
I've fixed the above mentioned issues.
gimp-2.0pre2 has just been released. It would be nice if the .ebuild for this would contain the above fix. :) @ brix : It's been added, thanks for your efforts. @ printing team : I gave this to you to fix, because you guys maintain the gimp-print ebuild, have the knowledge concerning print issues. The adaptations in the ebuild are straightforward and a few seconds to put in, but i wanted this tested by the proper herd before it got re-enabled. I don't have a printer, i can't test this. Passing it back to gnome is not helping one bit. So next time please do test & approve it at least and don't just push it back without doing anything. Oh and please do test now with 2.0_pre2 to make sure it works. |