Summary: | net-misc/tor-0.2.3.2_alpha-r2 fails to build with net-libs/miniupnpc-1.6 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Olivier Huber <oli.huber> |
Component: | Current packages | Assignee: | Anthony Basile <blueness> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | CC: | chiiph, jason, mgorny, nbkolchin |
Priority: | Normal | ||
Version: | 10.1 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://trac.torproject.org/projects/tor/ticket/5434 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
config.log
build.log quick and dirty patch libminiupnpc-1.6 |
Description
Olivier Huber
2011-07-27 15:05:51 UTC
attach also build.log Created attachment 281143 [details]
build.log
Okay that's strange. I'm not seeing that at my end. Can you sync your tree, re-emerge libnatpmp and then post the results of "equery f libnatpmp". (In reply to comment #3) > Okay that's strange. I'm not seeing that at my end. Can you sync your tree, > re-emerge libnatpmp and then post the results of "equery f libnatpmp". How libnatpmp can be related to this issue? The problem library is libminiupnpc. (In reply to comment #4) > (In reply to comment #3) > > Okay that's strange. I'm not seeing that at my end. Can you sync your tree, > > re-emerge libnatpmp and then post the results of "equery f libnatpmp". > > How libnatpmp can be related to this issue? The problem library is > libminiupnpc. It isn't, I meant to say miniupnpc. I'm not seeing a problem with either library so I'm not sure why you're hitting a missed dep at your end. Just to make sure, resync your tree, emerge net-libs/miniupnpc and then post the results of "equery f miniupnpc" I want to make sure you've got the .so Created attachment 281541 [details, diff]
quick and dirty patch libminiupnpc-1.6
Warning: With this patch, tor is able to compile. I didn't check for correct work at all!
In libminiupnpc-1.6 several functions have changed prototypes.
P.S. I was unable to find any bugtracker for Tor project. So, this issue was not reported upstream.
(In reply to comment #6) > Created attachment 281541 [details, diff] > quick and dirty patch libminiupnpc-1.6 > > Warning: With this patch, tor is able to compile. I didn't check for correct > work at all! > > In libminiupnpc-1.6 several functions have changed prototypes. > > P.S. I was unable to find any bugtracker for Tor project. So, this issue was > not reported upstream. Submit that patch upstream, in the mean time, I will depend on < 1.6 I don't know if it's related but this patch did not work with libminiupnpc-1.6-r1 and tor-0.2.3.10_alpha-r1, (I couldn't find tor-0.2.3.10_alpha-r2 in the portage tree). The patch applies correctly to tor-0.2.3.10_alpha-r1 but the emerge still fails with the same error of not finding the C header files for libminiupnpc. I had to downgrade to libminiupnpc-1.5 in order to upgrade to tor-0.2.3.10_alpha-r1. If you want to support both the new version and the old one in the same sources, you could use: #ifdef UPNPDISCOVER_SUCCESS /* miniupnpc-1.6 */ /* new code */ #else /* old code */ #endif Okay I submitted a patch upstream which is not quick and dirty. I'll be adding it to the tree in a minute with tor-0.2.3.12_alpha-r2. Please test. The patch was accepted upstream. Oops forgot to close. It will probably be out in tor-0.2.3.15_alpha. |