Summary: | net-misc/tor-0.2.3.2_alpha-r1 with USE=upnp has missing dependencies, and fails to build even with dependencies added | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexandre Rostovtsev (RETIRED) <tetromino> |
Component: | Current packages | Assignee: | Anthony Basile <blueness> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | candrews, chiiph |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Alexandre Rostovtsev (RETIRED)
2011-07-22 03:47:50 UTC
Attach full build.log please (In reply to comment #1) > Attach full build.log please I'd like to see this too, but I see the problem. I need a dep on net-libs/miniupnpc. Look for it in -r2. Thanks for testing! (In reply to comment #2) > (In reply to comment #1) > > Attach full build.log please > > I'd like to see this too Why waste bandwidth? Just look at the short the part of the log that I pasted, this is an elementary --as-needed linking problem. [...] -lm ../../common/libor.a [...] should be [...] ../../common/libor.a -lm [...] People, come on. When you see "undefined reference" in the error message, "-Wl,--as-needed" in the bug reporter's LDFLAGS, and no "-Wl,--as-needed" in your own LDFLAGS, the first thing you should be thinking of is "this probably has to do with --as-needed; let me check if the object files and libraries in the link command are listed in the correct order". Or in terms of the build system: have a look at src/tools/tor-fw-helper/Makefile.am: tor_fw_helper_LDADD = $(nat_pmp_ldadd) $(miniupnpc_ldadd) ../../common/libor.a @TOR_LIB_WS32@ Since $(miniupnpc_ldadd) contains "-lm", and ../../common/libor.a uses symbols from libm, ../../common/libor.a needs to come before $(miniupnpc_ldadd). (In reply to comment #4) > Or in terms of the build system: have a look at > src/tools/tor-fw-helper/Makefile.am: > > tor_fw_helper_LDADD = $(nat_pmp_ldadd) $(miniupnpc_ldadd) ../../common/libor.a > @TOR_LIB_WS32@ > > Since $(miniupnpc_ldadd) contains "-lm", and ../../common/libor.a uses symbols > from libm, ../../common/libor.a needs to come before $(miniupnpc_ldadd). Thanks, I noticed that as soon as I started debugging. There were two problems: 1) I need the depend, and 2) there is this problem in the build system. Both will be in -r2. Please test tor-0.2.3.2_alpha-r2 which I just added to the tree. Please test with respect to USE="upnp" and USE="nat-pmp". Its working for me, so I'm going to close this RESOLVED TEST-REQUEST. Feel free to reopen if this is still a problem. Open a different bug if you find a new problem. (In reply to comment #6) > Please test tor-0.2.3.2_alpha-r2 which I just added to the tree. Please test > with respect to USE="upnp" and USE="nat-pmp". Its working for me, so I'm going > to close this RESOLVED TEST-REQUEST. Feel free to reopen if this is still a > problem. Open a different bug if you find a new problem. Thank you, tor-0.2.3.2_alpha-r2 now builds for me with all combinations of upnp and nat-pmp USE flags. Marking as RESOLVED FIXED. |