Bug 37592

Summary:	Allow usage of distccmon as user to watch over portage compiling
Product:	Gentoo Linux	Reporter:	Ernst Bachmann <e.bachmann>
Component:	[OLD] Development	Assignee:	Lisa Seelye (RETIRED) <lisa>
Status:	RESOLVED LATER
Severity:	minor
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch to add missing check for errno==EPERM

Description Ernst Bachmann 2004-01-08 04:55:22 UTC

My user account is in group portage, so it has access to the .distcc dir used by portage, yet I still can't use distccmon-* to watch over it.

The problem is that it does a check for orphaned processes using the kill syscall, but doesn't check the return value correctly.

I reported this bug to the distcc-mailing list, but they don't seem to be very interrested, so maybe you could add this one-line patch to the distcc ebuild.


Reproducible: Always
Steps to Reproduce:
1. emerge something (FEATURES=distcc...)
2. try to run DISTCC_TMPDIR=/var/tmp/portage/.distcc distccmon-text 1
3. run the same under strace to clearly see the bug. (kill-syscalls failing with EPERM)

Actual Results:  
distccmon doesn't display any info as it regards every process as dead. 

Expected Results:  
It should display something :)

Comment 1 Ernst Bachmann 2004-01-08 04:57:23 UTC

Created attachment 23378 [details, diff]
patch to add missing check for errno==EPERM

One-line patch to src/mon.c that fixes the bug.

Comment 2 Lisa Seelye (RETIRED) gentoo-dev

2004-01-08 17:34:25 UTC

When Martin releases 2.12.1 I'll see if he put this patch into the code. If not I'll apply it and mark it ~arch.

Comment 3 Lisa Seelye (RETIRED) gentoo-dev

2004-01-09 09:32:31 UTC

2.12.1 addresses this.