| Summary: | New package: x11-terms/valaterm | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jacques-Pascal Deplaix <jp.deplaix> |
| Component: | New packages | Assignee: | Samuli Suominen (RETIRED) <ssuominen> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://git-jpdeplaix.dyndns.org/valaterm/valaterm.git/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
valaterm-0.3.ebuild
valaterm-0.3-r1.ebuild valaterm-0.4.2.ebuild valaterm-0.5.ebuild |
||
|
Description
Jacques-Pascal Deplaix
2011-05-23 19:34:59 UTC
Created attachment 274429 [details]
valaterm-0.3.ebuild
Created attachment 274473 [details]
valaterm-0.3-r1.ebuild
Created attachment 286915 [details]
valaterm-0.4.2.ebuild
0.4.3 is in portage now Created attachment 315913 [details]
valaterm-0.5.ebuild
This bug was for initial introduction of valaterm to Portage which has been completed. Do not reopen bugs like this. Version bumps go to new bug. Ok, I'm sorry for that. Can I have some explanations for your modifications on my ebuild ? 1) LICENSE="GPL-2" is wrong. ValaTerm is under GPL-3 2) src_prepare() is no longer necessary because of this commit: http://git-jpdeplaix.dyndns.org/valaterm/valaterm.git/commit/?id=4a8ecb533d3cd35650f1918442cfff035ec3a88b 3) Why did you remove the gtk3 USE flag ? (In reply to comment #7) > Ok, I'm sorry for that. np > Can I have some explanations for your modifications on my ebuild ? > 1) LICENSE="GPL-2" is wrong. ValaTerm is under GPL-3 Fixed. I think I've missed a change in the COPYING file or misread it. > > 2) src_prepare() is no longer necessary because of this commit: > http://git-jpdeplaix.dyndns.org/valaterm/valaterm.git/commit/ > ?id=4a8ecb533d3cd35650f1918442cfff035ec3a88b That will still prepend -s to LINKFLAGS which causes prestripping of the binary. Stripping is handled by Portage via FEATURES. Then it prepends -O optimization flag if user has no CFLAGS defined on his own. If it was only the CFLAGS case, I'd propably let it slip through, and no src_prepare() would be required, but figured while removing the -s from LINKFLAGS, I might add couple of more expressions in the same `sed` call "while at it" > > 3) Why did you remove the gtk3 USE flag ? Because valaterm is not a library with reverse dependencies which would still require different GTK+ version Even then it would be preferred to have /usr/lib64/libvalaterm-gtk2.so and libvalaterm-gtk3.so and they would be in SLOT="2" of valaterm-0.5-r200 and SLOT="3" of valaterm-0.5-r300 As in, adding versioned gtk USE flag is the absolute last resort and in fact has no valid use cases in Portage at all, and the ones that have such USE flag are bugs See bug 374057 and bug 420493 So conclusion... We can add 2 SLOT's of valaterm in Portage if valaterm with GTK+-2 has some features that GTK+-3 version doesn't and that they are important enough to cost the extra maintaince burden (In reply to comment #8) > That will still prepend -s to LINKFLAGS which causes prestripping of the > binary. Stripping is handled by Portage via FEATURES. > > Then it prepends -O optimization flag if user has no CFLAGS defined on his > own. > > If it was only the CFLAGS case, I'd propably let it slip through, and no > src_prepare() would be required, but figured while removing the -s from > LINKFLAGS, I might add couple of more expressions in the same `sed` call > "while at it" > Ok, I changed that in this commit: http://git-jpdeplaix.dyndns.org/valaterm/valaterm.git/commit/?id=a7530301784601ab0da1a41dd088e1b16a5c7fdb It will be available in the next release. |
