Summary: | media-video/2mandvd-1.5.5 fails to patch | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Juergen Rose <rose> |
Component: | Current packages | Assignee: | Tomás Touceda (RETIRED) <chiiph> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Adrian.Bassett, chris, qt, radfoj, vikraman |
Priority: | Normal | ||
Version: | 10.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
/var/tmp/portage/media-video/2mandvd-1.5.5/temp/2mandvd-fix-const-char-concatenation.patch.out
updated 2mandvd-1.5.5.ebuild Corrected ebuild, still with patch and other fixes patch |
Description
Juergen Rose
2011-04-23 07:28:14 UTC
Created attachment 270941 [details]
/var/tmp/portage/media-video/2mandvd-1.5.5/temp/2mandvd-fix-const-char-concatenation.patch.out
We don't really need this patch if we replace all occurrences of "qApp->applicationDirPath()" with QString ("/usr/share/${PN}/"). I've updated the ebuild to do the same and it works for me. Please review. Created attachment 270969 [details]
updated 2mandvd-1.5.5.ebuild
Updated ebuild, doesn't require patch, please see previous comment.
More than one day later after 'emerge --sync' I still get the same error. (In reply to comment #4) > More than one day later after 'emerge --sync' I still get the same error. The fix hasn't yet been committed, you can try manually, download my ebuild and replace the one in tree, regenerate the digest, and emerge again. Please let me know the results. Tested on my system, the proposed ebuild works just fine, thanks Created attachment 271037 [details]
Corrected ebuild, still with patch and other fixes
Created attachment 271039 [details]
patch
Uploaded ebuild still uses the useless patch, I've uploaded it anyway because find's die has to be removed and tar's messages can be filtered out. The patch from Comment 3 worked for me. Fixed. Thanks everyone for your input. |