Summary: | www-client/firefox-bin-4.0 fails when setting locale | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Marco Leogrande <dark.knight.ita> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | 6012030, anigel, creideiki+gentoo-bugzilla, emdej, gentoo, gorkypl, kroemmelbein, mani, manyac, pierino.the.living.joke, t.scheller, tomas |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
firefox-bin-4.0.ebuild patch
Patch to the current ebuild to make it work |
Description
Marco Leogrande
2011-03-31 09:38:11 UTC
I also have this bug. same here - x86 with 'linguas_pl'. same on x86 with 'linguas_de' same on x86, with linguas_ru Created attachment 268203 [details, diff]
firefox-bin-4.0.ebuild patch
to apply patch:
mkdir -p /usr/local/portage/www-client
cp -rv /usr/portage/www-client/firefox-bin /usr/local/portage/www-client
cd /usr/local/portage/www-client/firefox-bin
patch < firefox-bin-4.0.patch
(In reply to comment #4) > same on x86, with linguas_ru ok, seems there is typo. lines 135-136 or so in file /usr/portage/www-client/firefox-bin/firefox-bin-4.0.ebuild: sed -e "s:general.useragent.locale\", \"en-US\":general.useragent.locale\", \"${LANG}\":" \ -i "${D}${MOZILLA_FIVE_HOME}"/defaults/pref/${MY_PN}.js \ -i "${D}${MOZILLA_FIVE_HOME}"/defaults/pref/${MY_PN}-l10n.js || \ the ${D}'s are superflous. here is workaround: 1. make a local copy for ebuild: mkdir -p /usr/local/portage/www-client cp -rv /usr/portage/www-client/firefox-bin /usr/local/portage/www-client 2. patch /usr/local/portage/www-client/firefox-bin/firefox-bin-4.0.ebuild with supplied patch: cd /usr/local/portage/www-client/firefox-bin patch <firefox-4.0.patch or just remove ${D} from sed args. should looks like this: sed -e "s:general.useragent.locale\", \"en-US\":general.useragent.locale\", \"${LANG}\":" \ -i "${MOZILLA_FIVE_HOME}"/defaults/pref/${MY_PN}.js \ -i "${MOZILLA_FIVE_HOME}"/defaults/pref/${MY_PN}-l10n.js || \ 3. update manifest: ebuild firefox-bin-4.0.ebuild manifest 4. check you have your local portage tree in path, your /etc/make.conf should contain something like PORTDIR_OVERLAY="/usr/local/portage" 5. emerge firefox-bin (In reply to comment #6) > the ${D}'s are superflous. Hmm, not quite. Removing the ${D} you edit the files on the live filesystem, breaking sandboxing. I'll attach the patch that I've been using locally, that substitutes the sed in the ebuild with an "echo" that works. Created attachment 268209 [details, diff]
Patch to the current ebuild to make it work
The sed line is changed with a redirected echo, that creates the (now missing) preference file.
Patch from comment #8 works fine on ~amd64 Works fine on x86 too. (In reply to comment #9) > Patch from comment #8 works fine on ~amd64 I second that This seems to have been fixed with the patch submitted by comment #8, i.e. almost two weeks ago. Is there a reason this has not been merged into portage, yet? Mozilla Gentoo Team in hollidays ? :) (In reply to comment #13) > Mozilla Gentoo Team in hollidays ? :) As the main active developer for all mozilla ( minus seamonkey ) -bin packages fall into the class of when I get to them. As it stands I will be sending out an email announcing that if we do not find someone to maintain -bin packages we will p.mask and remove from tree. *** Bug 364777 has been marked as a duplicate of this bug. *** FYI, the patched ebuild seems to work also if bumped to firefox-bin-4.0.1.ebuild Fixed in CVS thanks for providing the patch :) |