Summary: | =net-misc/tor-0.2.2.23_alpha-r1 appends CFLAGS="-O2" by itself | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | New packages | Assignee: | Anthony Basile <blueness> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | chiiph |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Agostino Sarubbo
2011-03-27 13:20:09 UTC
Okay, I guess the question here is, what do we mean by "respects CFLAGS"? On =net-misc/tor-0.2.2.23_alpha-r1 (and only that ebuild for experimentation) I made it so the user can override *any* CFLAGS by doing CFLAGS="-O1" emerge =net-misc/tor-0.2.2.23_alpha-r1 Then you get x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/share\"" -DLOCALSTATEDIR="\"/var/lib\"" -DBINDIR="\"/usr/bin\"" -I../../src/common -O1 -Wall -g -O2 -fno-strict-aliasing -O1 -MT dnsserv.o -MD -MP -MF .deps/dnsserv.Tpo -c -o dnsserv.o dnsserv.c Notice the -O1 ... -O2 ... -O1. Since -O1 is last it will override the default -O2. Thus the user's CFLAGS are respected *over* the build system's default. What you're asking is that I remove the build system's default CFLAGS of -g and -O2 and respect user CFLAGS. Let me look at this again. CFLAGS="-march=native" emerge -av tor: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/common -march=native -Wall -g -O2 -fno-strict-aliasing -MT crypto.o -MD -MP -MF .deps/crypto.Tpo -c -o crypto.o crypto.c -O2 and -g are included :P Please test again. I did not rev bump tor-0.2.2.23_alpha-r1 because this is a minor change does not affect users who have already compiled tor on their systems. it works! closed as resolved fixed ;) |