Bug 35873 - GNUnet should allow "-gtk" USE flag
Bug#: 35873 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: eradicator@gentoo.org Reported By: Sebastian@SSpaeth.de
Component: Ebuilds
URL: 
Summary: GNUnet should allow "-gtk" USE flag
Keywords:  
Status Whiteboard: 
Opened: 2003-12-15 06:52 0000
Description:   Opened: 2003-12-15 06:52 0000 
Currently the gnunet package depends on X,gtk, etc...
This is because of the GTK client. However, it is an optional client and can be disabled in ./configure. Therefore a "-X" USE flag should disable the building of the GTK client and remove the "X" dependency.
I am new to Gentoo and it will take a while to figure the (rather trivial) solution out. If somebody is faster than me... you are welcome to contribute this.

------- Comment #1 From Sebastian Spaeth 2003-12-15 07:34:29 0000 ------- 
Turned out to be quite easy (portage seems really nice). I haven't tried it out
to actually compile it. Will report here if anything breaks. I need help with
the checkin (never did it, don't know the procedure).

One open issue (how do I determine the *default* state of a USE flag. I suppose
'gtk' should be turned on by default.

diff gnunet-0.6.0a.ebuild gnunet-0.6.0b.ebuild
21c21
<       =x11-libs/gtk+-1.2*
---
>       gtk? (=x11-libs/gtk+-1.2*)
26c26
<       econf `use_enable ipv6` || die
---
>       econf `use_with gtk` `use_enable ipv6` || die

------- Comment #2 From Sebastian Spaeth 2003-12-15 07:45:07 0000 ------- 
adapt bug title to reflect reality. We need IUSE="gtk" not "X" here

------- Comment #3 From Sebastian Spaeth 2003-12-15 08:38:03 0000 ------- 
Last post for now (sorry for the number of postings):
1) I compiled with and without gtk installed and everything went fine. So it works
2) Of course one should use "gtk? ( =x11-libs/gtk+-1.2* )" AND NOT 
   "gtk? (=x11-libs/gtk+-1.2*)" (as indicated in my diff)
3) I kept the gtk+ dependency as it was. I don't know whether it would work with gtk+2 as well. Probably it should be changed to ">=" ? (or leave it for now as is).

Thanks for considering my (first and probably clumsy) patch :)

------- Comment #4 From Nick Hadaway 2004-01-29 22:20:50 0000 ------- 
I don't use this package... (yet!)  mholzer, as you were the last one to commit
on gnunet... I bequeath this bug to you :)

------- Comment #5 From Jeremy Huddleston (RETIRED) 2004-03-22 23:03:01 0000 ------- 
gtk, mysql, and crypt USE flags added...