Summary: | media-sound/sonic-rainbow-0.2.3.ebuild (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Josh Glover (RETIRED) <jmglov> |
Component: | New packages | Assignee: | Jeremy Huddleston (RETIRED) <eradicator> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | polesz, sound |
Priority: | High | Keywords: | EBUILD |
Version: | 1.4 | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://sonic-rainbow.sourceforge.net/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
media-sound/sonic-rainbow-0.2.3.ebuild (New Package)
media-sound/sonic-rainbow-0.2.3-r2.ebuild (Update) media-sound/sonic-rainbow-0.5.1.ebuild (Update) |
Description
Josh Glover (RETIRED)
2003-12-15 06:40:13 UTC
Created attachment 22244 [details]
media-sound/sonic-rainbow-0.2.3.ebuild (New Package)
Created attachment 22245 [details]
media-sound/sonic-rainbow-0.2.3-r2.ebuild (Update)
Need a patch for now due to a problem with how the mkdir() function is invoked.
Could you update this ebuild for the latest release? Created attachment 28002 [details]
media-sound/sonic-rainbow-0.5.1.ebuild (Update)
I have updated the ebuild to install the most recent version of Sonic-Rainbow,
but an egregious hack was required to make it work:
-=-=-= sonic-rainbow-0.5.1.ebuild =-=-=-
src_compile() {
econf || die 'configure script failed'
sed -i -e 's|/usr/share|${DESTDIR}/usr/share|g' Makefile
emake || die 'make failed'
}
-=-=-=-=-=-=-
The reason is that the 'install-data-local' target in the Makefile is ignoring
the DESTDIR macro:
-=-=-= Makefile =-=-=-
install-data-local:
@$(NORMAL_INSTALL)
if test -d $(srcdir)/pixmaps; then \
$(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/pixmaps; \
for pixmap in $(srcdir)/pixmaps/*; do \
if test -f $$pixmap; then \
$(INSTALL_DATA) $$pixmap $(DESTDIR)$(pkgdatadir)/pixmaps; \
fi \
done \
fi
if test -d $(srcdir)/doc; then \
$(mkinstalldirs) /usr/share/Sonic-Rainbow/doc; \
$(INSTALL_DATA) $(srcdir)/doc/Sonic-Rainbow.html
/usr/share/Sonic-Rainbow/doc/Sonic-Rainbow.html; \
fi
if test -d $(srcdir)/icons; then \
$(mkinstalldirs) /usr/share/icons; \
$(INSTALL_DATA) $(srcdir)/icons/sonic-rainbow_drag.xpm
/usr/share/icons/sonic-rainbow_drag.xpm; \
fi
-=-=-=-=-=-=-
This causes 'make install' to error out, and the emerge fails:
-=-=-= `emerge sonic-rainbow` =-=-=-
if test -d ./pixmaps; then \
/bin/sh ./mkinstalldirs
/var/tmp/portage/sonic-rainbow-0.5.1/image//usr/share/sonic-rainbow/pixmaps; \
for pixmap in ./pixmaps/*; do \
if test -f $pixmap; then \
/usr/bin/install -c -m 644 $pixmap
/var/tmp/portage/sonic-rainbow-0.5.1/image//usr/share/sonic-rainbow/pixmaps; \
fi \
done \
fi
if test -d ./doc; then \
/bin/sh ./mkinstalldirs /usr/share/Sonic-Rainbow/doc; \
/usr/bin/install -c -m 644 ./doc/Sonic-Rainbow.html
/usr/share/Sonic-Rainbow/doc/Sonic-Rainbow.html; \
fi
mkdir /usr/share/Sonic-Rainbow
ACCESS DENIED mkdir: /usr/share/Sonic-Rainbow
mkdir: cannot create directory `/usr/share/Sonic-Rainbow': Permission denied
mkdir /usr/share/Sonic-Rainbow/doc
ACCESS DENIED mkdir: /usr/share/Sonic-Rainbow/doc
mkdir: cannot create directory `/usr/share/Sonic-Rainbow/doc': Permission
denied
ACCESS DENIED open_wr: /usr/share/Sonic-Rainbow/doc/Sonic-Rainbow.html
/usr/bin/install: cannot create regular file
`/usr/share/Sonic-Rainbow/doc/Sonic-Rainbow.html': Permission denied
make[2]: *** [install-data-local] Error 1
-=-=-=-=-=-=-
My hack works, but it ain't pretty. I will contact the author and see if he can
fix it. I don't know enough about AutoTools to know how to fix it myself, or I
would submit a patch to him. If anyone else wants to take a look and send me
and/or the author a patch, that would be appreciated.
Hey Josh... your ebuild is very clean... I see you've submitted a lot to gentoo over the past few months... have you ever considered becoming a dev? We could really use the help. now in portage, thanks. It's generally best to patch the bad Makefile... that sedage might've broken something else, but I didn't try it. *** Bug 440232 has been marked as a duplicate of this bug. *** |