Bug 352360

Summary:	sys-power/upower shouldn't check for CONFIG_ACPI_SYSFS_POWER since kernel 2.6.37
Product:	Gentoo Linux	Reporter:	jeff <aliencowboy>
Component:	Current packages	Assignee:	Freedesktop bugs <freedesktop-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	chris, chrschmitt, dan, matrix47, rzubaly, tomas
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description jeff 2011-01-21 19:08:45 UTC

Upower-0.9.8 requires active CONFIG_ACPI_SYSFS_POWER.
With the latest kernel (2.6.37) this option is obsolete and doesn't exist.

Reproducible: Always

Comment 1 Henrique Dias 2011-01-21 20:09:47 UTC

I have the same problem!

I can not find the option CONFIG_ACPI_SYSFS_POWER in the kernel configuration (kernel-config-x86_64-2.6.37-gentoo)...

>>> Installing (1 of 1) sys-power/upower-0.9.8

 * Messages for package sys-power/upower-0.9.8:

 *   CONFIG_ACPI_SYSFS_POWER:	 is not set when it should be.
 * Please check to make sure these options are set correctly.
 * Failure to do so may cause unexpected problems.
>>> Auto-cleaning packages...

>>> No outdated packages were found on your system.

Comment 2 Christian Schmitt 2011-01-21 22:06:46 UTC

yes, it's obvious that the check should be limited to kernels <2.6.37. I don't think the option was just renamed and still exists somewhere else.

Comment 3 Daniel M. Weeks 2011-01-22 08:27:16 UTC

I believe this is the relevant kernel commit:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.37.y.git;a=commit;h=1b3d4c3b9a597e216c08bff2c59a8de872ef2d09

It looks like what was an option is now always built when sysfs is enabled on >=2.6.37. This should just check for CONFIG_SYSFS on >=2.6.37.

Comment 4 jeff 2011-01-22 11:15:26 UTC

(In reply to comment #3)
> I believe this is the relevant kernel commit:
> 
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.37.y.git;a=commit;h=1b3d4c3b9a597e216c08bff2c59a8de872ef2d09
> 
> It looks like what was an option is now always built when sysfs is enabled on
> >=2.6.37. This should just check for CONFIG_SYSFS on >=2.6.37.
> 

In my kernel this option is enabled.

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2011-01-28 16:35:13 UTC

Fixed in 0.9.8. Removed 0.9.7. 0.9.5 won't be fixed, we'll wait for 0.9.8 to stabilize instead:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/upower/upower-0.9.8.ebuild?r1=1.2&r2=1.3