Summary: | sys-apps/gnome-disk-utility: file browser is hard-coded to nautilus instead of using xdg-open | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Delan Azabani <delan> |
Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | g.livid, v_2e, xfce |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | https://bugzilla.gnome.org/show_bug.cgi?id=638938 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | screenshot of the error |
Description
Delan Azabani
2011-01-07 00:55:49 UTC
Created attachment 259106 [details]
screenshot of the error
Looks like it's intentional looking at src/palimpsest/gdu-section-volumes.c: static void on_fs_mount_point_element_activated (GduDetailsElement *element, const gchar *uri, gpointer user_data) { GduSectionVolumes *section = GDU_SECTION_VOLUMES (user_data); GError *error; gchar *s; /* We want to use nautilus instead of gtk_show_uri() because * the latter doesn't handle automatically mounting the mount * - maybe gtk_show_uri() should do that though... */ s = g_strdup_printf ("nautilus \"%s\"", uri); error = NULL; if (!g_spawn_command_line_async (s, &error)) { GtkWidget *dialog; dialog = gdu_error_dialog_new (GTK_WINDOW (gdu_shell_get_toplevel (gdu_section_get_shell (GDU_SECTION (section)))), gdu_section_get_presentable (GDU_SECTION (section)), _("Error spawning nautilus: %s"), error); gtk_widget_show_all (dialog); gtk_window_present (GTK_WINDOW (dialog)); gtk_dialog_run (GTK_DIALOG (dialog)); gtk_widget_destroy (dialog); g_error_free (error); } g_free (s); } I think you should open this bug to upstream instead since we will need their approval at first: http://bugzilla.gnome.org + 07 Jan 2011; Pacho Ramos <pacho@gentoo.org> gnome-disk-utility-2.32.0.ebuild: + gnome-base/nautilus is always required since it's not only used for nautilus + extension (bug #350919 by Delan Azabani). And reported upstream: https://bugzilla.gnome.org/show_bug.cgi?id=638938 reopen. nautilus is now being pulled in by xfce's and lxde's deptrees, it's not required. and reverted the commit in tree. *** Bug 351501 has been marked as a duplicate of this bug. *** Please comment on following suggestions to handle this since I doubt upstream will fix it in the near future: 1. Add a "minimal" USE flag allowing people to skip nautilus installation even having a original problem (comment #0) when clicking on the link to the mountpoint. 2. Use "xdg-open" instead of "nautilus" for src/palimpsest/gdu-section-volumes.c: > /* We want to use nautilus instead of gtk_show_uri() because > * the latter doesn't handle automatically mounting the mount > * - maybe gtk_show_uri() should do that though... > */ > > s = g_strdup_printf ("nautilus \"%s\"", uri); > But, as stated by upstream, you should try to know of nautilus alternatives will "handle automatically mounting the mount" Thanks for your help I would prefer option 2. to use xdg-open, but I don't think upstream will accept it because xdg-utils is not maintained, last release is from 2007 or so, propably the only project in whole freedesktop.org not migrated to git yet. We have been shipping CVS snapshots of it, like every other distro do... But still, all that said, it would be easy to maintain a single line sed in the ebuild. So I'd still choose option 2. Or put it behind USE=nautilus, behind --enable/--disable-nautilus, if upstream wants to keep using nautilus for palimpsest, let them, just build the app only when nautilus is wanted Or leave it as is, optional drop in runtime dep, not a big deal -> resolved, wontfix I would probably choose to use xdg-open but I was doubting since maybe xdg-open behaves as "gtk_show_uri()" (I mean, both don't mount the mount) +*gnome-disk-utility-2.32.0-r1 (17 Jan 2011) + + 17 Jan 2011; Samuli Suominen <ssuominen@gentoo.org> + +gnome-disk-utility-2.32.0-r1.ebuild: + Use xdg-open instead of nautilus when accessing mountpoint from palimpsest + wrt #350919 by Delan Azabani. I don't quite understand the need for the file manager to mount the volume on open. The only time when you see the mountpoint link is after you've mounted a volume. Oh, whoops. I didn't notice that it was already resolved and changed to xdg-open. Sorry! |