Bug 349206

Summary:	app-office/krita-2.2.2 fails with media-gfx/exiv2-0.21 due to API changes
Product:	Gentoo Linux	Reporter:	Ulrich Plate <u.plate>
Component:	Current packages	Assignee:	Andreas K. Hüttel <dilfridge>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, polidevk.polidevk, sbriesen, zeekec
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch for krita-2.2.2 so it compiles with exiv2-0.21

Description Ulrich Plate 2010-12-20 16:22:03 UTC

Similar to bug 349150 and bug 349160, I suppose. revdep-rebuilding krita after upgrading to exiv2-0.21 ends in:

[ 26% ] Building CXX object
krita/ui/CMakeFiles/kritaui.dir/kisexiv2/kis_exif_io.o
[ 26% ] Building CXX object
krita/ui/CMakeFiles/kritaui.dir/kisexiv2/kis_exiv2.o
/var/tmp/portage/app-office/krita-2.2.2/work/krita-2.2.2/krita/ui/kisexiv2/kis_exif_io.cpp:
In member function ‘virtual bool KisExifIO::saveTo(KisMetaData::Store*,
QIODevice*, KisMetaData::IOBackend::HeaderType) const’:
/var/tmp/portage/app-office/krita-2.2.2/work/krita-2.2.2/krita/ui/kisexiv2/kis_exif_io.cpp:409:50:
error: ‘tagType’ is not a member of ‘Exiv2::ExifTags’
/var/tmp/portage/app-office/krita-2.2.2/work/krita-2.2.2/krita/ui/kisexiv2/kis_exif_io.cpp:422:73:
error: ‘tagType’ is not a member of ‘Exiv2::ExifTags’
/var/tmp/portage/app-office/krita-2.2.2/work/krita-2.2.2/krita/ui/kisexiv2/kis_exif_io.cpp:424:70:
error: ‘tagType’ is not a member of ‘Exiv2::ExifTags’
/var/tmp/portage/app-office/krita-2.2.2/work/krita-2.2.2/krita/ui/kisexiv2/kis_exif_io.cpp:428:56:
error: ‘tagType’ is not a member of ‘Exiv2::ExifTags’
make[2]: *** [krita/ui/CMakeFiles/kritaui.dir/kisexiv2/kis_exif_io.o] Error 1

This obsoletes bug 349091 comment 7.

Comment 1 Ulrich Plate 2010-12-20 16:24:36 UTC

Ahem. That'll be bug 349091 comment 5, of course. Sorry.

Comment 2 Kamen Dokov 2010-12-21 15:59:35 UTC

Yeah same here .... krita fails ;)

Comment 3 Robert Cabrera 2010-12-21 20:53:08 UTC

I too can confirm on my ~x86 laptop that upgrade to media-gfx/exiv2-0.21 causes build of app-office/krita-2.2.2 to fail at the same point as above.

Steps to reproduce:
1) emerge -uavND brings in new version of exiv2
2) completing emerge triggers, "!!! existing preserved libs:" etc.....
3) emerge @preserved-rebuild brings in several apps including app-office/krita-2.2.2 which fails to build as previously mentioned.

Comment 4 Neil Cathey 2010-12-22 06:20:01 UTC

Created attachment 257736 [details, diff]
Patch for krita-2.2.2 so it compiles with exiv2-0.21

Here is a patch from upstream.

https://projects.kde.org/projects/calligra/repository/revisions/7f6b2f2b9b2be1e4f257582a04b194c69f705bc7/diff/krita/ui/kisexiv2/kis_exif_io.cpp

Comment 5 Robert Cabrera 2010-12-22 09:57:24 UTC

Can anyone verify if the upstream patch works? If so, any chance of getting it included into portage soon?

Comment 6 Ulrich Plate 2010-12-22 12:42:54 UTC

Perfect. Compilation finished successfully using that patch. Thanks for the quick fix!

Comment 7 Neil Cathey 2010-12-22 23:51:18 UTC

(In reply to comment #5)
> Can anyone verify if the upstream patch works? If so, any chance of getting it
> included into portage soon?
> 

Sorry, I guess I should have mentioned that the patch works for me.

Comment 8 Andreas K. Hüttel archtester

2010-12-23 00:10:18 UTC

Added as ~arch krita-2.2.2-r1. Please test and give feedback here.

Comment 9 Robert Cabrera 2010-12-23 00:23:37 UTC

(In reply to comment #8)
> Added as ~arch krita-2.2.2-r1. Please test and give feedback here.
> 

I haven't synced yet to see if how the new ebuild works, but I have applied the upstream patch in my local portage overlay to the old ebuild and it compiled and installed as expected. The application appears to function as it did before. So this patch seems to work as intended.

I hope this helps.

Comment 10 Kamen Dokov 2010-12-23 04:22:59 UTC

The new ebuild compiles fine!

[SOLVED] ;)