Summary: | dev-tex/catdvi-0.14 does not compile with dev-libs/kpathsea-6.0.0_p20100722 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Martin Väth <martin> |
Component: | Current packages | Assignee: | Ulrich Müller <ulm> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | tex |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Fix to change type of kpathsea_version_string
catdvi-0.14-kpathsea.patch |
Description
Martin Väth
2010-10-26 19:33:23 UTC
Created attachment 252093 [details, diff]
Fix to change type of kpathsea_version_string
Unfortunately, your patch breaks compilation with app-text/texlive-core-2009-r2: gcc -O -march=core2 -ggdb -O2 -pipe -DCFG_HAS_GETOPT_LONG -c -o kpathsea.o kpathsea.c kpathsea.c: In function ‘version_findtfm’: kpathsea.c:39: error: conflicting types for ‘kpathsea_version_string’ /usr/include/kpathsea/version.h:24: note: previous declaration of ‘kpathsea_version_string’ was here make: *** [kpathsea.o] Error 1 make: *** Waiting for unfinished jobs.... Created attachment 252099 [details, diff]
catdvi-0.14-kpathsea.patch
Variable kpathsea_version_string should be declared in kpathsea header files, so I believe that we can simply remove the declaration.
Does attached patch fix the problem for you?
Yes, it works. It is clearly the better solution. Fixed in -r1. Thank you for reporting and for pinpointing the problem. iirc kpathsea/version.h wasn't available with kpathsea versions prior to texlive 2008 (or was it 2007?) and kpathsea_version_string wasn't declared in any header. That's why I used such a patch instead: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/freetype/files/freetype-1.4_pre20080316-kpathsea_version.patch?revision=1.1&view=markup if its already included unconditionaly then it's good to remove the extra define though. Thanks for this info. It is included from kpathsea.h, but only in TL 2009. So I guess we have to detect version.h in configure and explicitly include it. Fixed again, thanks Alexis. (The build system of this package is strange, by the way.) @Martin: Could you report this bug upstream, too? There's not much activity, but I think it should be done anyway. Thank you again. Since this bug is referenced from the upstream tracker, our fix is here: <http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-tex/catdvi/files/catdvi-0.14-kpathsea.patch?view=markup> |