Bug 33296 - sge 030809 ( New Package )
|
Bug#:
33296
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: x86
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: games@gentoo.org
|
Reported By: magnet@suidzer0.org
|
|
Component: Games
|
|
|
URL:
http://www.etek.chalmers.se/~e8cal1/sge/index.html
|
|
Summary: sge 030809 ( New Package )
|
|
Keywords: EBUILD
|
|
Status Whiteboard:
|
|
Opened: 2003-11-12 04:28 0000
|
SGE is an add-on graphics library for the Simple Direct Media Layer.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Created an attachment (id=26621) [details]
Version Bump
Since i didn't know there was an ebuild, i wrote my own. Take a look at it, it
works for me and i don't know what the already existing ebuild does different.
Mine looks much simpler :)
I made this ebuild because it's a dependencie for a games I was packaging.
I did not success with the game,so I don t plan to take care of the package( exept if a dev ask me ).
your ebuild seems ok to me.trough , the truetype support is optional ( look my ebuild ).
also you didn t named the ebuild, so we don t know for which version of sge it's working.
the additional sed I was doing were needed by the version of sge I used.
Thanks for the info. The "sed" part no longer seems to be needed. AFAIK it
installs correct.
I will try to mix both ebuilds to enhance mine with your truetype support.
The only thing is that their version numbers are in MMDDYY-format and not in
YYMMDD as usual. Will try if i can find a solution for that.
for your date trouble, you can still name in YYMMDD format , then use sed in
the ebuild to correct the package's name.
like echo ${PV} | sed 's,\(..\)\(..\)\(..\),\3\1\2,g' .
The version numbers are, as far as I can tell, *not* in MMDDYY format as
previously said, but actually in YYMMDD format: version 030809 is likely from
September 09, 2003, seeing as how we are not yet in the year 2009.
Therefore (and this is confirmed at the package's homepage), 030809 is the
latest version.
I have modified the initial ebuild (for sge-030809) to:
-Use the proper license (LGPL-2.1, not GPL-2), as in LICENSE
-List sed as a build dependency (required for src_compile)
(do I assume correctly that 'make', 'gcc' etc. need not be listed, if no
specific version is needed?)
-Use PV rather than 030809 in several places
-Use a local USE flag, 'image', to indicate whether to depend on sdl-image
(sdl-image provides _optional_ support for PNG-based bitmap-fonts)
-Install the example source files (as docs)
I will attach this updated ebuild file after a couple more tests and
looks-over.
Additionally, I am emailing the author about PREFIX et al. flags. Perhaps then,
in future versions we will not have to use 'sed' to edit the silliness in
Makefile.conf!
Created an attachment (id=27327) [details]
Improved ebuild for SDL Graphics Extension
In addition to the features I described in an earlier comment, this ebuild
removes 2 lines and a blank line from ${S}/examples/README, which described how
to use 'make' to compile the example applications. These instructions would not
work unless ${S}/Makefile.conf was also installed, and the examples folder was
made user-writable. The example source files are still all there, providing
examples of how to do things. The README still describes the function of each
of these examples.
This ebuild should be put in media-libs, like most of the SDL-related libraries
(some language-specific SDL libraries, such as pygame and RUDL, are in their
respective dev-[language] directories)
Thanks.
Tested and working on amd64. Thanks for the ebuild.
*** Bug 57087 has been marked as a duplicate of this bug. ***
Created an attachment (id=78538) [details]
Rename and a few fixes
I feel the ebuild should be called sdl-sge-030809.ebuild to similar to other
"addons" to the SDL library already in the portage tree. Also included another
mirror, rearanged order so inheritance will not kill description and changed it
to be little more detailed.
(From update of attachment 78885 [details])
This is a patch to fix SGE's collisionmap set/clear functions for large
collisionmaps.
- do MY_P="sge${PV}" and use that instead hardcoding twice
- emake install should be make DESTDIR=${D} install otherwise we'll run into
sandbox violations
- doc/${P} should be doc/${PF}
Created an attachment (id=82448) [details]
sdl-sge-030809.ebuild
Changes:
- Fixed problems pointed out by carlo
- Use our CXXFLAGS
- epatch doesn't need die
- Removed unneeded files from dodoc
- Made html docs optional
- Removed depend on sed >=4 as everyone has this now
- Force SDL_image/FreeType support on or off regardless of what is found on the
system
- Build examples and install them with their source (Had to use make -j1...)
Steve, I wasn't sure whether your patch should be used by default so I left it
out (Commented)
My patch is needed for a game I am developing. Without the patch a large
surface causes the collision map set and clear methods to segfault.
I am also wondering why this is still not in portage. Are there any humoungus
problems with this package I am not seeing or is it just a lack of a
maintainer?
> My patch is needed for a game I am developing. Without the patch a large
> surface causes the collision map set and clear methods to segfault.
please take this patch upstream
> I am also wondering why this is still not in portage. Are there any humoungus
> problems with this package I am not seeing or is it just a lack of a
> maintainer?
lack of a maintainer
(In reply to comment #20)
> > My patch is needed for a game I am developing. Without the patch a large
> > surface causes the collision map set and clear methods to segfault.
>
> please take this patch upstream
I actually emailed him a while ago, but he has not responded and since the last
release was in '03 I don't think I can get a hold of him.
I've successfully tested the ebuild with games-action/stransball2 in bug
#109199.
> I actually emailed him a while ago,
then can you explain what the patch does and the problem it's solving ?
(In reply to comment #25)
> > I actually emailed him a while ago,
>
> then can you explain what the patch does and the problem it's solving ?
It changes the 16bit integers for setting and clearing collision maps to 32bit
because if the surface is too large the program will segfault.
What about putting it in portage?
the src_install needs to be fixed up to not mv or rm files out of ${S}. It's
an error to not be able to run src_install over and over again and get the same
output in ${D}.
(In reply to comment #28)
> the src_install needs to be fixed up to not mv or rm files out of ${S}. It's
> an error to not be able to run src_install over and over again and get the same
> output in ${D}.
>
I don't see where it does that.
ah, nm. I didn't notice the cd to ${D}
really the 'use examples' logic needs to be cleaned up and then i'd have no
problem with adding the package
Any hints regarding the 'use examples' mess?
Also, there are still problems with the Makefile...
The original sge_config.h isn't being overwritten. A tmp fix was 'rm
sge_config.h' in src_unpack.
After that, it builds fine but sdl_image and freetype are still linked if
they're found. I assume that shouldn't happen.
better to keep patches for sep issues sep rather than merging them into one big
mondo patch
makes it a huge pita down the road with upgrades/upstream/etc... when it's just
one big patch
cleaned up and added to portage, thanks everyone
with doins the example binary get installed with wrong permission.
I don't know if that is wanted.
there should be no example binaries
ive removed the compile steps from src_compile()
