Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 331747

Summary: www-servers/thttpd removal(?)
Product: Gentoo Linux Reporter: Thilo Bangert (RETIRED) (RETIRED) <bangert>
Component: New packagesAssignee: www-servers Herd (OBSOLETE) <www-servers+disabled>
Status: RESOLVED FIXED    
Severity: normal CC: gef.kornflakes
Priority: High    
Version: 1.0   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 241464, 273319, 327615    
Attachments: Fix illegal PATH_INFO
Patch from bug #327615 to fix "Setting clock backwards hangs a web-server"
Use the X-Forwarded-For header
Enforce using the Status header
Fix makefile.in's to respect CFLAGS #241464
Patch against in-tree thttpd-2.25b-r7.ebuild

Description Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2010-08-09 10:46:53 UTC
Dear treecleaners,

please remove thttpd. noone in www-servers maintains it, it has not seen a release in years, and three open issues, some of them for a long time.

thanks
Comment 1 Gef 2010-08-09 13:13:35 UTC
Hi Thilo,
That's really my problem, but I use thttpd as a very light weighted CGI server in conjunction with nginx. I would be happy to:
A) Be advised good opportunities
or
B) Be given a couple of days to have a look at the build-system and see if the two build-system related bugs can we solved
Comment 2 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2010-08-09 13:49:39 UTC
well - the most important reason for masking is the lack of a active upstream / maintainer.  If you find thttpd usefull, perhaps you can simply take over maintenance or fork it?

while adding patches over patches to it is not generally a problem, i am concerned about the package in the long run. with an inactive upstream life gets tough for a package... ;-)

lets see what you come up with.
thanks
Comment 3 Gef 2010-08-09 21:25:53 UTC
Thanks for letting as least trying :)

So here is a first shot:
* EAPI=2
* repoman is running out of business
* respects CFLAGS and LDFLAGS (that should fix bug #241464)
* ported a few patches from several sources:
  - from ??????: use real ip (X-Forwarded-For: header)
  - from bug #327615: if possible, use MONOTONIC CLOCK (this has also been submitted in debian bug 588534)
  - from debian: fix-illegal-path-info
  - from debian: enforce using a Status: header on all locations

* wrt bug #273319: I would need some advice. I have chosen to keep he use of -static for compiling 5 files: redirect, phf, ssi, makeweb, thtpasswd. This files are normally copied into the cgi-bin directory of the configured vhost. As thttpd defaults to run chrooted, it makes sense to have theses binaries statically linked. However, if someone thinks security implication are just to strong, I can produce a conditional patch use based (the current one doesn't really work).

Feedback and suggestions on other enhancement will be appreciated. If that is just not enough to keep thttpd in the tree, let's get rid of it :)
Comment 4 Gef 2010-08-09 21:28:29 UTC
Created attachment 242153 [details, diff]
Fix illegal PATH_INFO
Comment 5 Gef 2010-08-09 21:29:30 UTC
Created attachment 242155 [details, diff]
Patch from bug #327615 to fix "Setting clock backwards hangs a web-server"
Comment 6 Gef 2010-08-09 21:30:19 UTC
Created attachment 242157 [details, diff]
Use the X-Forwarded-For header
Comment 7 Gef 2010-08-09 21:30:58 UTC
Created attachment 242159 [details, diff]
Enforce using the Status header
Comment 8 Gef 2010-08-09 21:32:19 UTC
Created attachment 242161 [details, diff]
Fix makefile.in's to respect CFLAGS #241464
Comment 9 Gef 2010-08-09 21:37:55 UTC
Created attachment 242163 [details, diff]
Patch against in-tree thttpd-2.25b-r7.ebuild
Comment 10 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2010-10-28 22:26:44 UTC
fixed in cvs. thanks for your work!