Summary: | sys-boot/gnu-efi-3.0i - multiple QA issues | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Dane Smith (RETIRED) <c1pher> |
Component: | Current packages | Assignee: | IA-64 team <ia64> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | c1pher, fauli, tomka |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 329715 | ||
Attachments: |
Ebuild diff for gnu-efi-3.0i
Patch for crt0-efi-ia32.S Patch for setjmp_i32.S |
Description
Dane Smith (RETIRED)
2010-07-25 20:28:49 UTC
Created attachment 240139 [details]
Ebuild diff for gnu-efi-3.0i
Will use the following patches.
Created attachment 240141 [details]
Patch for crt0-efi-ia32.S
Fixes the first of the QA Warnings.
Created attachment 240143 [details]
Patch for setjmp_i32.S
Fixes the second of the QA Warnings.
ia64, can you go on and proceed with the fixes (or at least review them)? if the EFI objects are only used in low level boot code (i.e. outside of Linux), then adding gnu stack markers to the objects doesnt make sense (In reply to comment #5) > if the EFI objects are only used in low level boot code (i.e. outside of > Linux), then adding gnu stack markers to the objects doesnt make sense So what would be a proper solution here? if the .o are only used low level and not under Linux, then they should get a QA_xxx exemption in the ebuild Soe the proposed solution is to -) include DEPEND="dev-util/patchutils" -) add QA_EXECSTACK="libgnuefi.a:setjmp_ia32.o crt0-efi-ia32.o" to the ebuild. maintainers, please do, or tell me to do it myself. should be all set now in the tree; thanks for the report! Commit message: Disable QA checks on compiled objects as they do not make sense for bootloaders http://sources.gentoo.org/sys-boot/gnu-efi/gnu-efi-3.0s.ebuild?rev=1.1 |