Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 329121

Summary: app-editors/gvim - dropped mips keywords
Product: Gentoo Linux Reporter: Jim Ramsay (lack) (RETIRED) <lack>
Component: Current packagesAssignee: MIPS Porters <mips>
Status: RESOLVED FIXED    
Severity: normal CC: maxposedon, vim
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Jim Ramsay (lack) (RETIRED) gentoo-dev 2010-07-20 14:19:12 UTC
I'm not sure exactly how this happened, it was before my time as vim maintainer, but the mips keyword was dropped some time between vim-7.0 and vim-7.1

If you have a chance, I'd appreciate if you would consider adding ~mips to vim-7.2 so I can clean out the old 7.0 versions eventually, and i don't want to deprive you of your vimmy goodness.

Thanks :)
Comment 1 Maksim 'max_posedon' Melnikau 2010-08-17 22:46:16 UTC
vim-7.2.442 cross compiles for mips after adding...
# vim
vim_cv_toupper_broken=no
vim_cv_terminfo=yes
vim_cv_tty_group=world
vim_cv_getcwd_broken=no
vim_cv_stat_ignores_slash=yes
vim_cv_memmove_handles_overlap=yes
to mips-linux-gnu in crossdev site

will tomorrow test how it runs on Ben Nanonote, but should be fine.
Comment 2 Maksim 'max_posedon' Melnikau 2010-08-18 19:32:48 UTC
confirm that 7.2.442 successfully runs on mips (Ben Nanonote), plz add ~mips keyword


===
I have no name!@BenNanoNote / # uname -a
Linux BenNanoNote 2.6.32.10 #1 PREEMPT Tue Jun 15 17:53:33 CEST 2010 mips GNU/Linux
I have no name!@BenNanoNote / # vim --version
VIM - Vi IMproved 7.2 (2008 Aug 9, compiled Aug 18 2010 01:40:47)
Included patches: 1-442
Modified by Gentoo-7.2.442
Compiled by root@max_posedon
Comment 3 Jim Ramsay (lack) (RETIRED) gentoo-dev 2010-08-19 16:41:59 UTC
(In reply to comment #2)
> confirm that 7.2.442 successfully runs on mips (Ben Nanonote), plz add ~mips
> keyword

So, to be perfectly clear: Are ebuild changes necessary to add those 'vim_cv'... things you mention in comment #1?  Or does adding ~mips to the current ebuild fulfill all requirements?

As a further request, if you wouldn't mind also checking the new vim-7.3 and gvim-7.3, that would be nice.  The new 7.3 version is basically 7.2.442 with some more bugfixes and a couple new features, but nothing groundbreaking or overly disruptive, so I'm pretty sure just adding ~mips will be okay - Just as sanity check would be nice.
Comment 4 Maksim 'max_posedon' Melnikau 2010-08-19 17:26:37 UTC
(In reply to comment #3)
> So, to be perfectly clear: Are ebuild changes necessary to add those
> 'vim_cv'... things you mention in comment #1? 
no, this vim_cv shouldn't goes to ebuild, they should goes to crossdev, and connected only with cross compilation.

> Or does adding ~mips to the current ebuild fulfill all requirements?
yes, just add ~mips keyword plz, nothing more


> As a further request, if you wouldn't mind also checking the new vim-7.3 and
> gvim-7.3, that would be nice.  The new 7.3 version is basically 7.2.442 with
> some more bugfixes and a couple new features, but nothing groundbreaking or
> overly disruptive, so I'm pretty sure just adding ~mips will be okay - Just as
> sanity check would be nice.
I'll happy do it when #bug 333247, will be closed. 
And even before, I'll try suggested patch and report results.
Comment 5 Maksim 'max_posedon' Melnikau 2010-08-19 20:56:50 UTC
With fix in #bug 333247 , I confirm that vim works on mips (Ben Nanonote). See comments there.
Comment 6 Maksim 'max_posedon' Melnikau 2010-09-06 17:31:49 UTC
any news?
Comment 7 Stuart Longland (RETIRED) gentoo-dev 2010-09-27 10:45:04 UTC
vim-7.3 works flawlessly on mipsel (o32 ABI) whereas vim-7.0 dies with a SIGABRT.  I've just taken the liberty of booting out keywords from vim-7.0 for that reason.

I am just updating the O2's portage tree, and will give it a try on big-endian MIPS before I add ~mips to the keywords.  (I'm confident it'll work but best to make sure.)

gvim will have to wait until I get X installed on these systems... or until I ugrade vim on the Yeeloong, which is my only MIPS machine with working X at the moment.
Comment 8 Stuart Longland (RETIRED) gentoo-dev 2010-09-27 21:18:11 UTC
Keywords added on vim-7.3.

I notice one of the tests failed on the O2, I'll investigate this further, but manual testing of vim showed that it did work enough to be useful.  It passed all tests on the other systems however... and once I rebuild the O2 I'll retry vim there too.  Sadly portage does not save ${T}/build.log when src_test fails, but I suspect the problem is with the O2's somewhat dated userland.
Comment 9 Matt Turner gentoo-dev 2010-12-07 17:50:44 UTC
I've been running vim-7.3 and 7.3.50 on a mips64/n32 system for as long as they've been in the tree. Looks like vim is good to go.

Adjusting the summary accordingly. No idea when I'll be able to test gvim.

Oh, go ahead and boot out the old versions. :)
Comment 10 Jim Ramsay (lack) (RETIRED) gentoo-dev 2010-12-30 18:40:14 UTC
(In reply to comment #9)
> Oh, go ahead and boot out the old versions. :)

Done.  Thanks!
Comment 11 Jim Ramsay (lack) (RETIRED) gentoo-dev 2010-12-30 18:41:14 UTC
Oops, sorry, shouldn't have closed this, since it's still valid for gvim.  Reopening.
Comment 12 Matt Turner gentoo-dev 2011-07-10 23:58:18 UTC
Added ~mips.