Summary: | dev-libs/glib-2.22.5 fails to build on hardened ppc64: glib-2.6.3-testglib-ssp.patch fails to apply | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Anthony Basile <blueness> |
Component: | Hardened | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hardened |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | PPC64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Add -fno-stack-protector to CFLAGS in glibs' tests/Makefile.in |
Description
Anthony Basile
2010-06-21 02:44:59 UTC
Created attachment 236115 [details, diff]
Add -fno-stack-protector to CFLAGS in glibs' tests/Makefile.in
This patch does exactly what the original did, but applies correctly.
Same issue with 2.22.5. Is the patch still needed btw ? (In reply to comment #3) > Is the patch still needed btw ? Good call. I just assumed that it still needed ssp off. Actually I tried the following change and it compiled and linked fine with some gnome apps that use libglib-2.0.so.0. --- glib-2.22.5.ebuild.orig 2010-08-14 12:35:59.000000000 -0400 +++ glib-2.22.5.ebuild 2010-08-19 17:38:37.000000000 -0400 @@ -26,11 +26,6 @@ ~app-text/docbook-xml-dtd-4.1.2 )" src_prepare() { - if use ppc64 && use hardened ; then - replace-flags -O[2-3] -O1 - epatch "${FILESDIR}/glib-2.6.3-testglib-ssp.patch" - fi - if use ia64 ; then # Only apply for < 4.1 local major=$(gcc-major-version) Could you please test directly with glib-2.24? + 08 Sep 2010; Gilles Dartiguelongue <eva@gentoo.org> glib-2.20.5-r1.ebuild, + glib-2.22.4.ebuild, glib-2.22.5.ebuild, glib-2.24.1-r1.ebuild, + glib-2.24.2.ebuild: + Drop ppc64 hardened patch, closes #324899. Dropped the patch per comment #4. Thanks for reporting. |