Bug 32220 - mkxf86config.sh script and Gentoo config.in
|
Bug#:
32220
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: x86
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: desktop-misc@gentoo.org
|
Reported By: liamh@thevenue.org
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: mkxf86config.sh script and Gentoo config.in
|
|
Keywords: EBUILD
|
|
Status Whiteboard:
|
|
Opened: 2003-10-28 13:54 0000
|
Created from the knoppix package, with a patch to match the Gentoo default
files directories. Seems to be running automatically from the hwsetup program
when running autoconfig -> I guess there's a hook in there I didn't know about.
Awfully convenient though!
A few ideas:
1) Move all the stuff in DEPEND to RDEPEND, and keep glibc there.
2) Do you need the dodirs? I don't even see the point of the /bin one.
3) I'd be very surprised if you tested it on all those architectures. Only
keyword it for archs you've tested, and do it ~arch, not arch.
4) You're missing all the header info at the top. You can get it from /usr/portage/skel.ebuild.
5) You need IUSE="" even if it's empty.
6) Try defining MY_P="xf86config-knoppix-${PV}" and using that in S and SRC_URI.
Please make the changes suggested by Donnie.
Also, neither of your patches applies for me per your epatch.
Please test this and submit a working patch.
Thanks ;)
--tseng
Created an attachment (id=22092) [details]
mkxf86config-0.7.ebuild
OK, sorry about the delay all -> life caught up with me and made me move, etc.
So, here's the new ebuild -> cleaned up based on your suggestions, dumped a
couple of things, and made extensive use of the MY_P variables.
Tell me if there's anything more to do on it, I actually have a little time
now.
As to the patches... ?? I redownloaded the file to make sure it hadn't changed,
but the patches still apply fine for me. Make sure that the file is named
correctly. Note: I changed the name of the file in the files directory in this
version of the ebuild, simply because I figured that the XF86Config.in included
with the distribution is unlikely to change frequently in subsequent versions.
Make sure the file is installed at
sys-apps/mkxf86config/files/mkxf86config-gentoo.patch
Bumped the ebuild and patch to 0.8-2. In CVS, thanks.