Summary: | gcc-4.5.0 optimizations break =games-util/grfcodec-0_pre2306, cause test failure in games-misc/opengfx | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | levertond, Wizzleby |
Priority: | High | Keywords: | InOverlay |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 915000 | ||
Attachments: |
Build log
grfcodec-0_pre2306.ebuild.patch |
Description
Diego Elio Pettenò (RETIRED)
2010-05-20 21:07:16 UTC
Created attachment 232289 [details]
Build log
I can confirm these test failures here, but can't track down from whence they emerge. Recommend RESTRICT=test until I can talk with upstream about this. I forgot to mention in my last comment, that Mr Bones does not seem to be able to replicate this behaviour. Updated ebuild with RESTRICT=test is in gamerlay overlay until I (or anyone else) can track this down. This is an issue with games-util/grfcodec built with gcc-4.5.0. Optimizations in gcc-4.5.0 seem to break grfcodec, leading to invalid compression, causing the opengfx test failure. Using -O0 fixes. Will attach a patch for the grfcodec ebuild (which hopefully won't require revbump, as gcc-4.5.0 is still masked, and this bug is exclusive to gcc-4.5.0. I'm not changing the ebuild to work around a masked and seemingly buggy gcc version. If it's a legitimate issue with the opengfx code then I'm interested, otherwise this is a WONTFIX. Created attachment 234347 [details, diff]
grfcodec-0_pre2306.ebuild.patch
Inherit flag-o-matic, filter optimizations, and append -O0.
This is now also in gamerlay. With this patch, which should only affect those of us testing gcc-4.5 (the issue exists in 4.5 branch built yesterday too), the RESTRICT=test can be removed from opengfx (it should never have affected users of stable/~arch gcc anyway)
This has been fixed upstream, so fixing bug 365957 will fix this too Version affected has been pruned by me. Thanks |