Bug 320731 – sys-power/pm-utils should not (or at most optionally) depend on xmlto

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Martin Väth 2010-05-20 14:15:54 UTC]

As was reported in bug 269339, the manpages in the pm-utils tarball come
pre-build, so there is no need for xmlto. I checked that this is also true
for the current pm-utils-1.3.0.

I understand that the automagick dependency should be removed, but one could
just *remove* the dependency in a patch and not make it *mandatory*
(BTW: If it is mandatory, it makes no sense to patch the automagic, anyway).

In fact, the comment in the ChangeLog about "small xmlto depend" is
wrong, since xmlto pulls in the horrible docbook-* and sgml-common stuff
(which all fill /etc/ with lot of useless crap after installation which is
not even under the control of portage - these packages are really horrible).
Moreover, especially on older laptops (where you will want to install
pm-utils) even a minor amount of disc space is a severe issue.

Although I see no point in regenerating a manpage existing in the tarball,
I ask to make this step at least optional.

[Comment 1 Samuli Suominen (RETIRED) 2010-05-20 16:25:19 UTC]

arggg, the patch shouldn't disable installing those pregenerated manpages like
it does.  it should only disable regenerating them.  manpages need to get
always installed.

[Comment 2 Martin Väth 2010-05-20 17:43:04 UTC]

Created attachment 232259 [details, diff]
Install manpages with or without xmlto

With the attached patch the manpages are installed no matter whether
you regenerate them with xmlto or not.
(You can combine it with the 1.3.0-fix_autotools.patch from the tree to
enable manual overriding of the automagic detection).

I tested it with DEPEND="", i.e. with none of docbook-* nor xmlto installed.
So, please also put DEPEND="" in a new ebuild (or at least allow this
optionally by some useflag).

[Comment 3 Samuli Suominen (RETIRED) 2010-05-20 17:50:12 UTC]

(In reply to comment #2)
> Created an attachment (id=232259) [details]
> Install manpages with or without xmlto
> 
> With the attached patch the manpages are installed no matter whether
> you regenerate them with xmlto or not.
> (You can combine it with the 1.3.0-fix_autotools.patch from the tree to
> enable manual overriding of the automagic detection).
> 
> I tested it with DEPEND="", i.e. with none of docbook-* nor xmlto installed.
> So, please also put DEPEND="" in a new ebuild (or at least allow this
> optionally by some useflag).
> 

looks good

+  20 May 2010; Samuli Suominen <[e-mail]>
+  pm-utils-1.3.0-r3.ebuild, +files/1.3.0-fix_autotools-2.patch:
+  Use pregenerated manpages wrt #320731 by Martin Väth.