Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 314791

Summary: dev-util/cvs crash on FreeBSD at cvs init
Product: Gentoo/Alt Reporter: Javier Villavicencio (RETIRED) <the_paya>
Component: FreeBSDAssignee: Maintainers for cvs, and cvs related tools (the version control system) [OBSOLETE] <cvs-utils+obsolete>
Status: RESOLVED FIXED    
Severity: normal CC: bsd+disabled, prefix
Priority: High    
Version: unspecified   
Hardware: All   
OS: FreeBSD   
URL: http://savannah.nongnu.org/bugs/?29466
Whiteboard:
Package list:
Runtime testing required: ---

Description Javier Villavicencio (RETIRED) gentoo-dev 2010-04-12 09:00:04 UTC
FreeBSD has slightly different wording for getdelim(), they expect a size=0 to append to the buffer, while on linux getdelim() expects a null pointer to do the same thing. Setting both (0/null) solves the problem.

Patch is tiny:
http://savannah.nongnu.org/bugs/download.php?file_id=20154

And already reported upstream.
Comment 1 Christian Faulhammer (RETIRED) gentoo-dev 2010-04-12 11:35:06 UTC
Looks fine on x86-fbsd.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-04-12 18:31:46 UTC
prefix: +1 for commit with revbump
Comment 3 Javier Villavicencio (RETIRED) gentoo-dev 2010-04-15 23:34:13 UTC
Fixed in cvs-1.12.12-r8, let me know if we want this on the masked versions too.

And it's already applied upstream:
http://cvs.savannah.gnu.org/viewvc/ccvs/src/myndbm.c?root=cvs&r1=1.38&r2=1.39