Summary: | app-admin/eselect-postgresql: libpq-fe.h symlink causes false detection of postgresql include paths | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | PgSQL Bugs <pgsql-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | titanofold |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Diego Elio Pettenò (RETIRED)
2010-04-08 00:49:19 UTC
libpq-fe.h in /usr/include is satisfactory for most builds. If a program needs more than that, they should be looking in /usr/include/postgresql/ or /usr/include/libpq/. “causing build failures if the package searches for the former and gets hit by the latter.” #if HAVE_LIBPQ_FE_H # include <libpq-fe.h> # include <pg_config_manual.h> #elif HAVE_POSTGRESQL_LIBPQ_FE_H # include <postgresql/libpq-fe.h> # include <postgresql/pg_config_manual.h> #endif I hope you can tell what I'm saying here. Oh, I see. When the package finds libpq-fe.h in /usr/include/ it expects pg_config_manual.h to be there as well and never looks any deeper down in the directory. I'll see what I can do. Bingo. FWIW I would consider that a bug in the buildsystem, but the same is true for packages looking for libpq-fe.h without using pg_config… I've submitted a fix for the package with this problem, but still, it might not be too bad to get this “fixed” in eselect-postgresql. (In reply to comment #4) > Bingo. > > FWIW I would consider that a bug in the buildsystem, but the same is true for > packages looking for libpq-fe.h without using pg_config… > > I've submitted a fix for the package with this problem, but still, it might not > be not too bad to get this “fixed” in eselect-postgresql. > Fixed that for you. See, I'm trying to figure that out now. But I don't know where the files are coming from. Have any hints as to where I might find some documentation? (In reply to comment #5) > (In reply to comment #4) > > Bingo. > > > > FWIW I would consider that a bug in the buildsystem, but the same is true for > > packages looking for libpq-fe.h without using pg_config… > > > > I've submitted a fix for the package with this problem, but still, it might not > > be not too bad to get this “fixed” in eselect-postgresql. > > > Fixed that for you. > > See, I'm trying to figure that out now. But I don't know where the files are > coming from. Have any hints as to where I might find some documentation? > Never mind. I figured it out. It's in the -base ebuild. (^_^) + 02 Jun 2010; Patrick Lauer <patrick@gentoo.org> + +postgresql-base-7.4.29-r1.ebuild, +postgresql-base-8.0.25-r1.ebuild, + +postgresql-base-8.1.21-r1.ebuild, +postgresql-base-8.2.17-r1.ebuild, + +postgresql-base-8.3.11-r1.ebuild, + +files/postgresql-base-8.4-9.0-heimdal_strlcpy.patch, + +postgresql-base-8.4.4-r1.ebuild, +postgresql-base-9.0_beta1-r1.ebuild: + Fixes for #313765, #251046, #294462, #300793, #274836, #296714, #238817, + #278228, #263096, #246397, #285953. Thanks to Aaron Swenson for collecting + the fixes and testing. |