Bug 311743

Summary:	x11-wm/compiz-0.8.4-r2 fails to build with gtk+ 2.20
Product:	Gentoo Linux	Reporter:	Guillaume ZITTA <gentoo.guillaume>
Component:	Current packages	Assignee:	Desktop-Effects herd <desktop-effects+disabled>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dan, lab, rose, tetromino
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://library.gnome.org/devel/gtk/unstable/GtkWidget.html#GTK-WIDGET-VISIBLE:CAPS
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	309237
Attachments:	path for gtk-window-decorator.c to use non deprecate instead of GTK_WIDGET_VISIBLE ebuild that use the patch

Description Guillaume ZITTA 2010-03-28 12:21:05 UTC

GTK-WIDGET-VISIBLE is deprecated since gtk+ 2.20
x11-wm/compiz-0.8.4-r2 fail to build

Reproducible: Always

Steps to Reproduce:
1.layman -a gnome
2.emerge -u  gtk+
3.emerge compiz

Actual Results:  
build fail :
gtk-window-decorator.o: In function `hide_tooltip':
/var/tmp/portage/x11-wm/compiz-0.8.4-r3/work/compiz-0.8.4/gtk/window-decorator/gtk-window-decorator.c:4236: undefined reference to `GTK_WIDGET_VISIBLE'
collect2: ld returned 1 exit status


Expected Results:  
build

OK, gtk+ 2.20 is in ovelay, but will someday come in main portage tree.

Comment 1 Guillaume ZITTA 2010-03-28 12:22:26 UTC

Created attachment 225551 [details, diff]
path for gtk-window-decorator.c to use non deprecate instead of GTK_WIDGET_VISIBLE

Comment 2 Guillaume ZITTA 2010-03-28 12:23:13 UTC

Created attachment 225553 [details]
ebuild that use the patch

Comment 3 Juergen Rose 2010-04-01 06:23:57 UTC

I have the same issue.

Comment 4 Daniel M. Weeks 2010-04-01 14:19:38 UTC

I was having the same issue. The zitta's patch and ebuild fixed the problem.

Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev

2010-04-01 21:21:43 UTC

This bug is fixed in compiz-0.8.6, which was released 4 days ago (not in portage yet).

Comment 6 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure

2010-04-03 06:04:04 UTC

Thanks for the patch. This has been fixed on compiz-0.8.4-r3 in the tree.
compiz-0.8.6 has also been added to the tree now.

Comment 7 Lincoln A Baxter 2010-04-04 20:21:52 UTC

(In reply to comment #6)
> Thanks for the patch. This has been fixed on compiz-0.8.4-r3 in the tree.
> compiz-0.8.6 has also been added to the tree now.
> 

I just tried to build with compiz-0.8.6 from portage.  It now gets a linker error: 

gtk-window-decorator.o: In function `hide_tooltip':
gtk-window-decorator.c:(.text+0x5bff): undefined reference to `gtk_widget_get_visible'
collect2: ld returned 1 exit status
make[3]: *** [gtk-window-decorator] Error 1
make[3]: Leaving directory `/var/tmp/portage/x11-wm/compiz-0.8.6/work/compiz-0.8.6/gtk/window-decorator'

Is this a new bug, or do we reopen this one?

Comment 8 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure

2010-04-05 00:45:43 UTC

Let's reopen the bug.

Comment 9 Lincoln A Baxter 2010-04-10 00:54:58 UTC

(In reply to comment #8)
> Let's reopen the bug.
> 

Ok... I forced an update of gtk+... by explicitly asking for it:

emerge --update --ask -v gtk+  #version on my system was not the most current
Then I rebuild compiz-fusion  and compiz linked fine

So with gtk+  2.18.6 it links.

Perhaps the bug can be closed after all.  ;-)

Lincoln

Comment 10 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure

2010-04-10 12:30:56 UTC

Closing the bug then. :)