Summary: | omnibook module does not compile after commit | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Tiago Batista <a19944> |
Component: | New packages | Assignee: | Markos Chandras (RETIRED) <hwoarang> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
This patch solves the build failure
Patch that solves the problem |
Description
Tiago Batista
2010-03-27 13:27:45 UTC
Created attachment 225447 [details, diff]
This patch solves the build failure
This patch solves the build problem described.
I introduced changes that are similar to those introduced on other drivers that call backlight_device_register()
This pach does add a compiler warning, but I believe the code is more readable like this. I am sure that the omnibook team will come up with a cleaner approach, but this is a working temporary solution.
Please review the patch, and if you feel comfortable with it, add to the omnibook ebuild
Created attachment 225449 [details, diff]
Patch that solves the problem
Sorry, the previous patch included the diff for the other patch that the portage already applies...
afaik this patch is only valid when kernel sources are > 2.6.33 right? (In reply to comment #3) > afaik this patch is only valid when kernel sources are > 2.6.33 right? > I tried to write a generic patch. I have not tested it with older kernels, but I hope I got the preprocessor statements right. If so, this pacth can be applied regardless of the running kernel version, as the preprocessor will choose the right code blocks to compile for each kernel. If I got it wrong, compiling against a non 2.6.34 kernel should error out when calling backlight_device_register() as the number of arguments vary with the version of the kernel. Ok thanks I commit your patch. Please try and send it to upstream as well Many thanks +*omnibook-20090628-r1 (29 Mar 2010) + + 29 Mar 2010; Markos Chandras <hwoarang@gentoo.org> + +files/backlight-2.6.34-omnibook-20090628.patch, + +omnibook-20090628-r1.ebuild: + Patch which fixes backlight compilation with kernels>=2.6.34. Thanks to + Tiago Batista <a19944@gmail.com> for the patch. Fixes bug #311621 + |